-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room - %baseURL room link in room leaving message in #admin room #35475
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @marcochavezf ( |
This is backend bug, no need to block on this. |
Source of the issue ended up being frontend actually (internal expensify slack link): https://expensify.slack.com/archives/C03TQ48KC/p1706738879615989 |
Fix for this was deployed 2 weeks ago, closing this. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #34694
Action Performed:
Expected Result:
In Step 3, no console error will show up
In Step 4, the room link in the room leaving message is a valid link
Actual Result:
In Step 3, console errors show up
In Step 4, the room link in the room leaving message is an valid link with %baseURL in it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6362319_1706708327790.bandicam_2024-01-31_17-28-31-124__1_.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: