Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - %baseURL room link in room leaving message in #admin room #35475

Closed
6 tasks done
lanitochka17 opened this issue Jan 31, 2024 · 5 comments
Closed
6 tasks done

Room - %baseURL room link in room leaving message in #admin room #35475

lanitochka17 opened this issue Jan 31, 2024 · 5 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34694

Action Performed:

  1. [User A] Create a private room and invite User B
  2. [User B] Leave the room
  3. [User A] Go to #admin room of the private workspace
  4. [User A] Click on the room link in room leaving message

Expected Result:

In Step 3, no console error will show up
In Step 4, the room link in the room leaving message is a valid link

Actual Result:

In Step 3, console errors show up
In Step 4, the room link in the room leaving message is an valid link with %baseURL in it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362319_1706708327790.bandicam_2024-01-31_17-28-31-124__1_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 31, 2024

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@francoisl
Copy link
Contributor

This is backend bug, no need to block on this.
cc @blimpich

@francoisl francoisl added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 31, 2024
@blimpich blimpich assigned blimpich and unassigned marcochavezf Jan 31, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 31, 2024
@blimpich
Copy link
Contributor

Source of the issue ended up being frontend actually (internal expensify slack link): https://expensify.slack.com/archives/C03TQ48KC/p1706738879615989

@blimpich
Copy link
Contributor

Fix for this was deployed 2 weeks ago, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants