Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-02-14] Pare back the parallax animation on empty chats #35172

Closed
roryabraham opened this issue Jan 25, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jan 25, 2024

slack context: https://expensify.slack.com/archives/C03TME82F/p1706131195305379

Problem

We've received feedback that, while cool, the parallax animation on the empty chat screens is a bit dizzying.

Solution

Twofold solution:

  1. Multiply this x and y by some number between 0 and 1 so that the animation is a bit more subtle. I suggest we start with 0.65, create an AdHoc build, then get feedback.
  2. Let's also create a separate PR to turn this animation off entirely if Reduced Motion accessibility setting is enabled at the OS level.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01893cf40458362b92
  • Upwork Job ID: 1755980203205128192
  • Last Price Increase: 2024-02-09
@roryabraham roryabraham added Weekly KSv2 Improvement Item broken or needs improvement. labels Jan 25, 2024
@roryabraham roryabraham self-assigned this Jan 25, 2024
@roryabraham
Copy link
Contributor Author

Put out a call for volunteers: https://expensify.slack.com/archives/C04878MDF34/p1706208017047929

@staszekscp
Copy link
Contributor

Hey @roryabraham! I can do that in between of HybridApp builds 😄

@staszekscp
Copy link
Contributor

staszekscp commented Jan 26, 2024

The PR is already available - I've added the Reduce Motion logic, because I think it is tightly connected to the general idea of the whole issue. If you prefer to split them anyway, please let me know 😄

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 7, 2024
@melvin-bot melvin-bot bot changed the title Pare back the parallax animation on empty chats [HOLD for payment 2024-02-14] Pare back the parallax animation on empty chats Feb 7, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-14. 🎊

@roryabraham roryabraham added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 8, 2024
@roryabraham
Copy link
Contributor Author

Marking this as a bug just to handle C+ payment to @situchan for his review of #35232

@sakluger sakluger added the External Added to denote the issue can be worked on by a contributor label Feb 9, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-02-14] Pare back the parallax animation on empty chats [$500] [HOLD for payment 2024-02-14] Pare back the parallax animation on empty chats Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01893cf40458362b92

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@sakluger sakluger removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2024
@sakluger
Copy link
Contributor

sakluger commented Feb 9, 2024

I added the external label to auto-generate the Upwork issue and sent @situchan an offer.

Wetting to weekly while we wait for the payment date.

@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Feb 9, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 13, 2024
@sakluger
Copy link
Contributor

All paid, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants