Feature request: Merchant field should display the required label in workspace expenses

[isagoico]

Feature Request: Add the required label to the merchant field in expenses

Problem:

The merchant field is required for all workspace expenses and it's not displaying the required label as the categories and tags does. Users might not be aware that the field is required and will have to clear the error after a first attempt on creating an issue.

Solution:

Add the required label to the merchant field in workspace expenses. This will save users a click since it's announced that the field is required.

Context/Examples/Screenshots/Notes:
This would also solve the inconsistency between the required label in the expense fields. In short words, if a single required field has the label, the rest of the required fields should also display it.

Raised by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705515336854489

Related project: Wave 9 violations

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[cead22]

I'm taking this one over and will work with IR to implement this, since it's similar to what we just did for violations. More context on this thread https://expensify.slack.com/archives/C049HHMV9SM/p1706050971212759?thread_ts=1705515336.854489&cid=C049HHMV9SM

[melvin-bot]

@cead22 Huh... This is 4 days overdue. Who can take care of this?

[cead22]

No updates yet, focused on other things including prioritizing other things related to violations

[melvin-bot]

@cead22 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cead22 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[cead22]

I'll try to prioritize this tomorrow and turn it into an issue that can be worked on by contributors

[cead22]

@lindboe please comment for assignment, thanks

[cdanwards]

Commenting for assignment

[melvin-bot]

@cead22, @cdanwards Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Could this maybe be part of this fix? #36574

[cead22]

This issue is already done, since the PR was merged, only thing left is payment. I'll comment on that other issue

[cead22]

Oh, now that I see that issue in detail, I think what you're saying is that the fix for this issue caused the one you linked. Looking at the PR for this issue, I don't think it was, but I think it was a PR for a violations issue that I reviewed this week, let me find it

[cead22]

I believe it was this one https://github.com/Expensify/App/pull/35641/files -- which Jayesh noted here #36574 (comment)

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @cdanwards eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!