Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Selected list item on pronoun page does not have highlighted background #34966

Closed
1 of 6 tasks
kavimuru opened this issue Jan 23, 2024 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Jan 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706004316917229

Action Performed:

Go to Settings > Profile > Pronouns

Expected Result:

The selected row for your pronouns should follow our standard list view styles and have a highlighted background color

Actual Result:

Selected row does not have highlighted background color

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Snip - (659) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ccbdbbc8d5e92e31
  • Upwork Job ID: 1749805783834763264
  • Last Price Increase: 2024-01-23
@kavimuru kavimuru added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 23, 2024
@melvin-bot melvin-bot bot changed the title Selected list item on pronoun page does not have highlighted background [$500] Selected list item on pronoun page does not have highlighted background Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ccbdbbc8d5e92e31

Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@ZhenjaHorbach
Copy link
Contributor

Dupe
#34749

@dipoletechi
Copy link

dipoletechi commented Jan 23, 2024

Problem:
I understand that selected row doesn't follow the background color scheme same as other listing.
image

What is the root cause of that problem?
For the selected item background-color logic not applied

What changes do you think we should make in order to solve the problem?
On the place where we are setting up the tick checkbox, need to add logic for adding background-color

Copy link

melvin-bot bot commented Jan 23, 2024

📣 @dipoletechi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@ddipole
Copy link

ddipole commented Jan 23, 2024

Contributor details
Your Expensify account email: dharmandarjob@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~015cba50320aa632fa/

Copy link

melvin-bot bot commented Jan 23, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@abzokhattab
Copy link
Contributor

dupe of #34749

@rushatgabhane
Copy link
Member

agree
@dylanexpensify this is a dupe. let's close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants