[Performance] Implement more reassure tests

[mountiny]

Problem

In the first phase of the Reassure implementation, we focused on creating performance tests to ensure that important part of the app were working properly. We looked at the LHN (SidebarLinks), ReportScreen and Composer to monitor any potential regressions in the app. We also added performance tests using measureFunction API to the methods from SidebarUtils, ReportActionsUtils and ReportUtils .

Now we can also test other parts of the application as our overall goal is to have a robust system for checking for regression issues.

Solution

As part of our solution for regression monitoring, we are actively identifying the additional components and methods to add to our tracking list. This involves adding them to Reassure tests, which will allow us to monitor their performance and catch any potential issues early on.

Here is the updated list of components and functions to export to the community:

Components:

• components/OptionsList/BaseOptionsList - [HOLD for payment 2024-04-03] [PAY March 27][$250] [Reassure] Add reassure test for BaseOptionsList #38168
• components/InvertedFlatList/BaseInvertedFlatList
• components/Attachments/AttachmentCarousel
• components/EmojiPicker/EmojiPickerMenu
• components/Composer
• pages/workspaces/WorkspacesListPage
• pages/settings/Wallet/PaymentMethodList

Functions:

• getOptions(OptionsListUtils) - [HOLD for payment 2024-03-26] [Reassure] Add measureFunction test for getOptions #38165 @OlimpiaZurek
• formatSectionsFromSearchTerm(OptionsListUtils) - [HOLD for payment 2024-04-25] [$250] [Reassure] Add measureFunction test for formatSectionsFromSearchTerm #38166
• getMemberAccountIDsForWorkspace(PolicyUtils) - [HOLD for payment 2024-03-26] [$250] [Reassure] Add measureFunction test for getMemberAccountIDsForWorkspace #38167
• getAvatarsForAccountIDs (OptionsListUtils)
• getPersonalDetailsForAccountIDs(OptionsListUtils)
• getLastMessageTextForReport(OptionsListUtils)
• createOption(OptionsListUtils)
• getActivePolicies(PolicyUtils)
• getIneligibleInvitees(PolicyUtils)
• getPersonalDetailsByIDs (PersonalDetailsUtils)
• getAccountIDsByLogins(PersonalDetailsUtils)
• getLoginsByAccountIDs(PersonalDetailsUtils)
• getNewPersonalDetailsOnyxData(PersonalDetailsUtils)

Next components for which we want to add Reassure tests:

• SignInPage
• SearchPage
• NewChatPage
• MoneyRequestConfirmationList
• TaskAssignSelectorModal
• ReportParticipantPage
• RoomInvitePage
• RoomMembersPage
• EmojiPicker

The main scope of testing above components:

• rendering lists with multiple items (we try to add as much data as possible to get a more reliable result when it comes to potential regressions)
• scrolling performance
• onPress/onSelect action list item
• interactions with text input
• pressing the button

Additionally we'll use the measureFunction API to test and track the performance of methods from:

• EmojiPickerUtils
• OptionsListUtils
• PaymentUtils
• PersonalDetailsUtils
• PolicyUtils

Our goal is to focus on functions from the above list that contain heavy computations and are frequently used in the application.
We will continuously expand this tracking list by adding new components and methods that we identify during our daily work. This proactive approach allows us to catch any performance regressions early on, maintaining a fast and efficient user experience.
If you have any suggestions for further components/scope that we want to add performance tests for, or if you have already identified methods involving heavy calculations that are worth adding to the list, please feel free to contribute.

---

We should prioritize the list components first

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010343afd21b08bf6e
• Upwork Job ID: 1736750358470123520
• Last Price Increase: 2023-12-18

[melvin-bot]

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010343afd21b08bf6e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[mountiny]

c+ or BZ not needed for now

[OlimpiaZurek]

Hi, I'm Olimpia from Callstack - expert contributor group. I'd like to work on this.

[OlimpiaZurek]

@mountiny Here are the components/functions we should test first (marked as * those for which we could ask the community to add tests):

Lists :

• components/OptionSelector/BaseOptionsSelector.js
• components/OptionsList/BaseOptionsList.js *
• components/InvertedFlatList/BaseInvertedFlatList.js*

Components:

• pages/SearchPage.js
• pages/NewChatPage.js *
• pages/RoomInvitePage.js *
• pages/ReportParticipantsPage.js *
• pages/workspaces/WorkspacesListPage

Functions:

• getOptions(OptionsListUtils)
• formatSectionsFromSearchTerm(OptionsListUtils) *
• getMemberAccountIDsForWorkspace(PolicyUtils) *

At a later stage, we can add the test to the remaining components from initial list and these functions:

• getAvatarsForAccountIDs (OptionsListUtils)
• getPersonalDetailsForAccountIDs(OptionsListUtils)
• getLastMessageTextForReport(OptionsListUtils)
• createOption(OptionsListUtils)
• getActivePolicies(PolicyUtils)
• getIneligibleInvitees(PolicyUtils)
• getPersonalDetailsByIDs (PersonalDetailsUtils)
• getAccountIDsByLogins(PersonalDetailsUtils)
• getLoginsByAccountIDs(PersonalDetailsUtils)
• getNewPersonalDetailsOnyxData(PersonalDetailsUtils)

I'm also considering adding some quick instructions/tips related to testing with Reassure to README.md that could help the community implement these tests. I will prepare a separate PR for this.

[mountiny]

Thank you! That sounds great! @OlimpiaZurek

I'm also considering adding some quick instructions/tips related to testing with Reassure to README.md that could help the community implement these tests. I will prepare a separate PR for this.

Could you try to make these before holidays and we could export the issues for community over the holidays?

[OlimpiaZurek]

Sure, I'm working on it now.

[OlimpiaZurek]

@mountiny The PR with instructions is ready. I also opened a PR with Reassure tests for OptionsSelector.
The component we would like to test next is SearchPage.

Since I will be on vacation for the next two weeks, one of the developer from Callstack will take over this part.

[mountiny]

Thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[muttmuure]

Sorry, I've been a little too swamped this week to split these out into separate issues for the community to take. I will work on it early next week

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NOQA] Fix Reassure tests for SearchPage #37280

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@OlimpiaZurek] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[mountiny]

This is underway, we got 4 issues branched off

[mountiny]

I will create more issues

[mountiny]

We are still looking into some flakiness which is being worked on here #39913 so we would only create new tests after that is resolved.

[mountiny]

Lets close this one for now and I will look into creating more issues for functions in future