Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency with scroll to new message behavior #32269

Open
MonilBhavsar opened this issue Nov 30, 2023 · 31 comments
Open

Fix inconsistency with scroll to new message behavior #32269

MonilBhavsar opened this issue Nov 30, 2023 · 31 comments
Assignees
@MonilBhavsar
Labels
Weekly KSv2

Comments

@MonilBhavsar
Copy link
Contributor

Problem

Coming from discussion
#31627 (comment)

Scroll to new messages has different behaviour

Self-unread message:

  • after scrolling down to latest manually, LHN is still bold
  • after scrolling down by clicking "New messages" badge, LHN gets unbold

Unread message from others:

  • after scrolling down to latest manually, LHN gets unbold
  • after scrolling down by clicking "New messages" badge, LHN gets unbold

Solution

Make it consistent.
Decide the expected behaviour and fix it
@MonilBhavsar MonilBhavsar self-assigned this Nov 30, 2023
@MonilBhavsar MonilBhavsar added the Weekly KSv2 label Dec 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@MonilBhavsar
Copy link
Contributor Author

Will circle back

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2023
@MonilBhavsar
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
@MonilBhavsar
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@MonilBhavsar
Copy link
Contributor Author

Same^

@melvin-bot melvin-bot bot removed the Overdue label Jan 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@MonilBhavsar
Copy link
Contributor Author

Same

@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@MonilBhavsar
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2024
@MonilBhavsar
Copy link
Contributor Author

Same^

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@MonilBhavsar
Copy link
Contributor Author

Same

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2024
@MonilBhavsar
Copy link
Contributor Author

^Same

@melvin-bot melvin-bot bot removed the Overdue label Feb 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 2, 2024
@MonilBhavsar
Copy link
Contributor Author

Catching up from ooo, will be back to this soon after clearing daily issues

@melvin-bot melvin-bot bot removed the Overdue label Jul 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2024
@MonilBhavsar
Copy link
Contributor Author

Will circle back. Focussed on fast-api's issues

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
@MonilBhavsar
Copy link
Contributor Author

Same^

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 6, 2024
@MonilBhavsar
Copy link
Contributor Author

Focussed on fire cleanup

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
@MonilBhavsar
Copy link
Contributor Author

Circling back soon

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 27, 2024
@MonilBhavsar
Copy link
Contributor Author

Working partially this week, will circle back

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@MonilBhavsar
Copy link
Contributor Author

Same^

@melvin-bot melvin-bot bot removed the Overdue label Sep 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2024
@MonilBhavsar
Copy link
Contributor Author

Not a priority

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2024
@MonilBhavsar
Copy link
Contributor Author

Same^

@melvin-bot melvin-bot bot removed the Overdue label Sep 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@MonilBhavsar
Copy link
Contributor Author

Not a priority

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonilBhavsar MonilBhavsar

Labels
Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MonilBhavsar