Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] Workspace - Workspace in the workspace list is misaligned when deleted offline #32182

Closed
5 of 6 tasks
kbecciv opened this issue Nov 29, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Nov 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.5.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go offline.
  3. Go to Settings > Workspaces > Create a new workspace.
  4. Click on the three-dot menu > Delete workspace > Delete.

Expected Result:

The deleted workspace in the workspace list will not be misaligned.

Actual Result:

The deleted workspace in the workspace list is misaligned.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294683_1701267572977.bandicam_2023-11-29_22-07-35-482.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 29, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 29, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Nov 29, 2023

the problem is related with this PR

#31728

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue, because I am author of the broken PR.

@situchan
Copy link
Contributor

situchan commented Nov 29, 2023

Commented with root cause and solution on offending PR

@rezkiy37
Copy link
Contributor

I am preparing a PR, will open it soon.

@situchan
Copy link
Contributor

Happy to review PR if @puneetlath agrees

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 29, 2023
@rezkiy37
Copy link
Contributor

I've opened the PR for review.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot changed the title Workspace - Workspace in the workspace list is misaligned when deleted offline [HOLD for payment 2023-12-07] Workspace - Workspace in the workspace list is misaligned when deleted offline Nov 30, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Nov 30, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 1, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 1, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-07] Workspace - Workspace in the workspace list is misaligned when deleted offline [HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] Workspace - Workspace in the workspace list is misaligned when deleted offline Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@puneetlath
Copy link
Contributor

@puneetlath
Copy link
Contributor

All paid, thanks y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants