Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-08] [Drafts] Allow draft creation in App #32174

Closed
mountiny opened this issue Nov 29, 2023 · 12 comments
Closed

[HOLD for payment 2023-12-08] [Drafts] Allow draft creation in App #32174

mountiny opened this issue Nov 29, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Nov 29, 2023

Problem

The App code currently only creates processing reports, lets update the code so that if the policy is paid, we create expense report in OPEN state, which is also name drafts

Additionally now the NextSteps are only showing for draft reports, lets update it so they show for any expense reports on Paid policies

Solution

Implement the necessary changes

Issue OwnerCurrent Issue Owner: @sonialiap
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Nov 29, 2023
@mountiny mountiny self-assigned this Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [Drafts] Allow draft creation in App [HOLD for payment 2023-12-08] [Drafts] Allow draft creation in App Dec 1, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 1, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 8, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@akinwale, @sonialiap, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

@sonialiap $500 to @akinwale for their testing and review on the PR

@sonialiap
Copy link
Contributor

@akinwale $500 offer has been sent
Please confirm if we should create a regression test for this

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@akinwale
Copy link
Contributor

@akinwale $500 offer has been sent Please confirm if we should create a regression test for this

Accepted. Thanks!

This is a new feature, so no regression test required here.

@situchan
Copy link
Contributor

We started creating regression test for new features 3 months ago
https://expensify.slack.com/archives/C02NK2DQWUX/p1694591231219059

@mountiny
Copy link
Contributor Author

We should be creating new issues but for the drafts project, we will handle it in a separate issue

@sonialiap feel free to close once ready

@mountiny mountiny reopened this Dec 11, 2023
@mountiny
Copy link
Contributor Author

🤦

@sonialiap
Copy link
Contributor

Payment completed ✔️

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants