Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$125] [Form Provider Refactor] AddressForm #32064

Closed
luacmartins opened this issue Nov 27, 2023 · 20 comments
Closed

[$125] [Form Provider Refactor] AddressForm #32064

luacmartins opened this issue Nov 27, 2023 · 20 comments
Assignees
@Ollyws @luacmartins @zanyrenney @cdOut
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 27, 2023 •
edited
Loading

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/components/AddressForm.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d9d14f0105c78b4c
  • Upwork Job ID: 1729190075497373696
  • Last Price Increase: 2023-11-29
Issue OwnerCurrent Issue Owner: @cdOut
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 27, 2023
@luacmartins luacmartins self-assigned this Nov 27, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@luacmartins luacmartins mentioned this issue Nov 27, 2023
Closed
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Nov 27, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d9d14f0105c78b4c

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 27, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

@DylanDylann DylanDylann mentioned this issue Nov 27, 2023
Closed
6 tasks
@cdOut
Copy link
Contributor

cdOut commented Nov 29, 2023

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency and I would like to work on this task.

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] AddressForm [$500] [Form Provider Refactor] AddressForm Nov 29, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 29, 2023

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2023
@luacmartins luacmartins changed the title [$500] [Form Provider Refactor] AddressForm [$125] [Form Provider Refactor] AddressForm Nov 29, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 29, 2023

Upwork job price has been updated to $125

@devstar1014
Copy link

Hello, I can finish this work within a short period

@ghost
Copy link

ghost commented Nov 29, 2023

Dibs

@devstar1014
Copy link

Dibs

Good.

@luacmartins
Copy link
Contributor Author

@devstar1014 @AnshuAgarwal24 thanks for the interest, but we already assigned someone to this issue. Also, please make sure to get familiar with our contributing guidelines before posting.

This was referenced Nov 30, 2023
Closed
Merged
@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@luacmartins
Copy link
Contributor Author

We have a draft PR

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 4, 2023

@Ollyws, @luacmartins, @zanyrenney, @cdOut Huh... This is 4 days overdue. Who can take care of this?

@zanyrenney
Copy link
Contributor

@cdOut as the main assignee, please give updates on the GH issue.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 7, 2023

@Ollyws, @luacmartins, @zanyrenney, @cdOut Still overdue 6 days?! Let's take care of this!

@zanyrenney
Copy link
Contributor

bump @cdOut

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Dec 7, 2023
@cdOut
Copy link
Contributor

cdOut commented Dec 7, 2023

@zanyrenney PR currently waiting for review

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 1, 2024

This issue has not been updated in over 15 days. @Ollyws, @luacmartins, @zanyrenney, @cdOut eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 1, 2024
@cdOut
Copy link
Contributor

cdOut commented Jan 2, 2024

This is completed and merged.

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Jan 18, 2024
@zanyrenney
Copy link
Contributor

As SWM contributor, closing as payment not handled here! Thanks.

@blazejkustra blazejkustra mentioned this issue Feb 7, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ollyws Ollyws

@luacmartins luacmartins

@zanyrenney zanyrenney

@cdOut cdOut

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ollyws @luacmartins @zanyrenney @cdOut @devstar1014