Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-31] [TS migration] Migrate 'ReferralDetails' page to TypeScript #31991

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/ReferralDetailsPage.js 20
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@JKobrynski
Copy link
Contributor

The PR is ready for review!

Copy link
Author

melvin-bot bot commented Jan 18, 2024

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 22, 2024
Copy link
Author

melvin-bot bot commented Jan 22, 2024

@dylanexpensify
Copy link
Contributor

nice! quick and easy

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 24, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReferralDetails' page to TypeScript [HOLD for payment 2024-01-31] [TS migration] Migrate 'ReferralDetails' page to TypeScript Jan 24, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 24, 2024
Copy link
Author

melvin-bot bot commented Jan 24, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Jan 24, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-31. 🎊

Copy link
Author

melvin-bot bot commented Jan 24, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@tylerkaraszewski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@dylanexpensify
Copy link
Contributor

payment upcoming!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 30, 2024
@dylanexpensify
Copy link
Contributor

today!

@dylanexpensify
Copy link
Contributor

ah no payment needed?

@mananjadhav
Copy link
Collaborator

@dylanexpensify I should've been paid for this issue as I reviewed the PR.

@dylanexpensify
Copy link
Contributor

Payment summary:

Please request!

@JmillsExpensify
Copy link

$250 approved for @mananjadhav based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants