[HOLD for Payment 2023-12-04] Request money - Two options are highlighted after opening tag label second time

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.1-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31129

Action Performed:

Precondition: enable tags as a workspace's admin

1. Navigate to NewDot and log in as an employee
2. Click on FAB > Request money
3. Enter amount and select workspace
4. Click on Show more > Tags
5. Select any option
6. Open the tags label again

Expected Result:

Only one option is highlighted that was selected previously

Actual Result:

Two options are highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284356_1700508196798.Recording__26.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lanitochka17]

Production:

Recording.25.mp4

[srikarparsi]

Still working on setting up tags, asked a question in the issue. I'm pretty sure the regression came from that PR though and reverting it should fix it. @robertKozik could you take a look as well if you have a chance and see if the best plan is to revert or make a quick fix?

[luacmartins]

I'm gonna demote this issue to NAB since it's a very minor UI issue. We have a fix for it already, but I'd like it QAed since it introduced more logic.

[situchan]

We can close this as fixed in #30465.
I might be eligible for compensation for the efforts in PR review

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

Adding bug label to pay @situchan for the PR review

[luacmartins]

@sonialiap this issue is resolved (we had a dupe), but we still need to pay @situchan for the PR review. Could you please help with that?

[melvin-bot]

@sonialiap, @luacmartins, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

@situchan internal PR review $500 - offer sent - paid ✔️