Deploy Checklist: New Expensify 2023-11-10

[OSBotify]

Release Version: 1.3.98-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Upgrade to react-native-web v0.19.9 #24482
• Handle potential CORS issues during file downloads #25556
• add failure message when create a task error #26848
• [No QA] [TS Migration] FormActions lib #26883
• [No QA] Only one active deploy at a time #27399
• Handle invisible characters in forms #27414
• Fix settings page / status bugs #27482
• [TS migration] Migrate 'Device' lib to TypeScript #27709
• [No QA] [TS migration] Migrate 'Link.js' lib to TypeScript #28257
• RequestorStep: Fix forward ref #28454
• [TS migration] Migrate 'EmojiUtils.js' lib to TypeScript #28589
• Remove duplicate withOnyx calls #28866
• Update reimbursement account page to function component #29166
• [No QA] [TS migration] Migrate 'useKeyboardShortcut.js' hook to TypeScript #29226
• [TS migration] Migrate 'useCurrentReportID.js' hook to TypeScript #29264
• [No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661
• Make optimistic requests/IOUs/expense reports “hidden” #29681
• fix: 28941 LHN - Money Request removal offline does not update LHN correctly #29939
• [TS migration] Migrate 'SafeArea' component to TypeScript #29947
• Only allow certain filetypes for receipt uploads #29963
• Migrate animations to app assets and .lottie files #29975
• [TS migration] Migrate 'RNTextInput.js' component to TypeScript #30056
• check attachment msg after deleted parent action #30117
• [No QA] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript #30159
• [TS migration] Migrate 'getPermittedDecimalSeparator' lib to TypeScript #30160
• [No QA] [TS Migration] Migrate 'ImageWithSizeCalculation.js' component to TypeScript #30179
• [TS migration] Migrate TextWithEllipsis #30202
• Fix: Add not allowed sign for archived workspace. #30229
• Fix/issue 29899 #30232
• [TS migration] Migrate 'CurrentWalletBalance.js' component to TypeScript #30262
• fix: 24473 Deepliink - Keyboard displayed upon splash screen #30345
• Migrate Button.js to function component #30349
• Update Categories.md #30358
• [Form Provider Refactor] MoneyRequestMerchantPage #30420
• [TS Migration] Migrate CurrentUserPersonalDetailsSkeletonView to TypeScript #30441
• Fix error message for duplicate waypoint #30548
• fix: change moment of displaying chat after editing existed message #30564
• Optimistically set achData to null when VBBA is deleted #30597
• fix: goBack from 'I am a teacher' contact methods #30608
• fix: Chat - Skeleton placeholder flickers when opening chat with IOU in offline mode #30658
• fix: mapbox attribution controls getting hidden #30673
• remove double onyx in profile page  #30694
• fix: added new condition when we need to refetch data #30730
• [No QA] Add a worker to deploy community > help redirects  #30739
• fix copy text for split action #30742
• [TS Migration] Migrate ReportActionsSkeletonView and SkeletonViewContentLoader directories to TypeScript #30774
• [TS migration] Migrate 'Pressable' component to TypeScript #30777
• Update Radio Checkbox Design #30791
• [NoQA] Staggered approach to E2E tests #30793
• fix: correctly setting up the billable value of IOU #30802
• Bump expensify-common to not allow link with multiline alias text preceeded by header markdown #30808
• Update and rename Everything-About-Chat.md to get-to-know-expensify-chat #30811
• Fix/24141: Add error handling to readFilyAsync #30832
• [NoQA] chore(tests): unified utilities for mocking collections #30833
• Fix: Room - Removed users not display in Invite page #30836
• Fix incorrect email validation msg caused comma separated search term #30859
• change font size for code block in H1 #30876
• fix: allow creating Distance request from expense reports #30881
• Fix Lottie animations height when not playing #30901
• Fix: Inconsistency - No margin top on save button #30913
• Remove remaining uses of report.ownerEmail #30914
• Participants Invite Fix #30920
• Remove Global Nav and Sub Nav #30946
• [CP Staging] Fix app crash on Home Address Page #30959
• fix: app crashes when using deeplink to request new participants #30961
• [CP Staging] fix: remove wrong use of createRef #30962
• [ImgBot] Optimize images #30963
• [CP Staging] fix: displaying avatars in LHNOptionList #30965
• Fix: 2FA code should auto-submit after entering the code for the first time #30966
• Fix: Billable switch does not have top padding #30970
• fix: used initialScrollIndex instead of implementing initial focus ma… #30972
• [CP Staging] Revert "Left line/border of quoted text is not visible when hovering over it in Notes" #30978
• Adding Removing Members image #30980
• Update Removing-Members.md #30982
• [TS Migration] migrate usePrivatePersonalDetails.js to TypeScript #30993
• fix: pdf send attachment regression #30995
• Fix there is no subtitle on search option for a policy expense chat thread #30997
• [CP Staging] fix: correctly pass transactions and reportActions to LHN #31007
• [No QA] Fix babel.config metro plugins syntax #31008
• Revert "feat: add whitespace after inserting emoji via native keyboard" #31011
• [CP Staging] fix: 30988 New dot opens when navigate to the staging magic link, not abracadabra page #31014
• Update money request options for different room types #31025
• Add a new template for requesting a library to be added in package.json #31035
• Fix android keyboard doesn't show up and ios text input content doesn't scroll to bottom when edit message #31041
• Fix wrong placeholder alignment and broken autofill #31044
• fix: No space between description & show more option #31048
• [CP Staging] Fix: New room page is misaligned after page transition #31063
• [CP Staging] Bump the onyx version to 1.0.115 #31066
• fix: add null check to emoji suggestions #31072
• Update community redirects for Expensify Card disputes and statement #31082
• Adding multiple files to Auto-Reconciliation.md #31096
• [Snyk] Security upgrade electron from 25.8.2 to 25.9.4 #31122
• [NoQA] Skip the reassure ReportScreen tests until they are not flakey #31131
• [No QA] Trust input tag and diff between it and the most recent completed deploy #31161
• [ImgBot] Optimize images #31167
• [NoQA] Force building main branch version of the app #31175
• [NoQA] report.ownerEmail was just removed everywhere #31177
• [CP Staging] Change TextInput import to Text #31201
• [CP Staging] Revert https://github.com/Expensify/App/pull/31201 and https://github.com/Expensify/App/pull/29166 #31214
• [CP-staging] Revert "Handle invisible characters in forms" #31219
• [CP Staging] Revert "Remove duplicate withOnyx calls" #31231
• Revert 30972 fix/29780/change implementation of initial focused item #31262

Internal QA:

• Disable logs for staging and production native apps #30875 - @kidroca

Deploy Blockers:

• [$500] [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - App crashes when opening Bank account page #31188
• [C+ Checklist Needs Completion] [$500] Web - The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor #31190
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Distance - Distance request creation is looped #31191
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected #31192
• [HOLD for payment 2024-01-03] Settings - Animation in Settings is not smooth: background comes first then the animation #31196
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] IOU - Multiline format text is not preserved in the description #31199
• [$500] Workspace - Bank account setup page appears briefly when opening BA when BA is already set up #31207
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Workspace - Start over page is not shown when user quits bank account setup and revisits it #31212
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description #31217
• Money Request - Green dot doesn't appear after Money Request in LHN #31222
• [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] Scan-App crashes tapping on scan request split bill amount&merchant #31226
• mWeb - The animation is not loading at all when use is offline #31236
• Wallet - Error appears when system attempts to verify Onfido information #31237
• Chat - Compose box reappears when trying to edit a message, exit the chat and go to it again #31238
• IOU-In employee WS, the billable option in manual expense is auto moving #31240

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.98-0 🚀

[kavimuru]

Checking off the following PRs from the past builds:
#24482
#25556
#26848
#28454
#28589
#29264
#29681
#29947
#29963
#30056
#30117
#30160
#30202
#30229
#30232
#30262
#30345
#30349
#30358
#30548
#30564
#30597
#30608
#30658
#30673
#30694
#30730
#30742
#30777
#30808
#30859
#30876
#30881

#30959
#30961
#30962
#30963
#30965
#30966
#30970
#30978
#30980
#30982
#30995
#31007
#31011
#31014
#31025
#31044
#31048
#31063
#31066
#31072

[kavimuru]

#31082 is a PROD QA, can we check it off?
#29166 failing with #31188
#29939 failing with #31194 and reproducible in PROD, checking it off
#30774 failing with #31189
#30441 failing with #30362
#30920 failing with #31191

[kavimuru]

Regression is completed.

Unchecked PRs:

#31082 is a PROD QA, can we check it off?
#29166 failing with #31188
#29939 failing with #31194 and reproducible in PROD, checking it off
#30774 failing with #31189
#30441 failing with #30362
#30920 failing with #31191
#30901 failing with #31236

Open Blockers:
#31191
#31192
#31196
#31199
#31207
#31217
#31222
#31226
#31237
#31238
#31240
#31236

[roryabraham]

#31196 demoted, checking it off

[roryabraham]

#31217 resolved, checking it off

[roryabraham]

#29166 and #31201 were reverted in #31214, checking them off

[roryabraham]

Demoted #31207, checking it off

[roryabraham]

Demoted #31236, checking it off

[mountiny]

Demoted #31222 not reproducible and the expected behaviour has changed

[roryabraham]

#31238 is expected behavior, checking it off

[roryabraham]

Confirmed #31192 was fixed by #31262, checking both off

[roryabraham]

#31226 is fixed, checking it off

[roryabraham]

Only remaining items are:

• Wallet - Error appears when system attempts to verify Onfido information #31237
• Update Radio Checkbox Design #30791 - passed on web, appears blocked by Wallet - Error appears when system attempts to verify Onfido information #31237 on other platforms?

[roryabraham]

#31237 demoted, checking it off

[roryabraham]