Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions #30569

Closed
1 task
mountiny opened this issue Oct 30, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 30, 2023

Coming from here https://expensify.slack.com/archives/C05LX9D6E07/p1698193710179789

We have set up the reassure in the App with new option to use measureFunction to test performance of methods. Lets use this to cover the most crucial method in the app to ensure changes do not introduce big regressions in these methods which might already take long and are called often.

Let's focus on methods in ReportActionsUtils, SidebarUtils (getOptionData specifically) and ReportUtils

@mountiny mountiny changed the title [] Use measure [Tracking] Use measureFunction from reassure to cover performance testing of important functions Oct 30, 2023
@mountiny mountiny self-assigned this Oct 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Nov 8, 2023

this is being worked on

@mountiny mountiny added the Reviewing Has a PR in review label Nov 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 29, 2023
@mountiny
Copy link
Contributor Author

Making a steady progress 🚀

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title [Tracking] Use measureFunction from reassure to cover performance testing of important functions [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions Dec 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@mountiny
Copy link
Contributor Author

mountiny commented Dec 5, 2023

@OlimpiaZurek @adhorodyski This is all done, right?

@OlimpiaZurek
Copy link
Contributor

Hey @mountiny perf tests for methods from SidebarUtils and ReportActionUtils have already been done. Now I’m working on adding tests to ReportUtils. This will be the last part of this scope. PR should be ready by the EOD.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 8, 2023
@OlimpiaZurek
Copy link
Contributor

@mountiny PR is ready for review

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 11, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Weekly KSv2 and removed Daily KSv2 labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions [HOLD for payment 2023-12-20] [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions Dec 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@mountiny
Copy link
Contributor Author

Seems like we are all done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
Development

No branches or pull requests

2 participants