Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-02] DEV: Require cycle causing error "Cannot read property 'REPORT_COMMENT' of undefined" #30250

Closed
hannojg opened this issue Oct 24, 2023 · 1 comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@hannojg
Copy link
Contributor

hannojg commented Oct 24, 2023

I sporadically get an error when developing the android app. The error says "Cannot read property 'REPORT_COMMENT' of undefined":

When this error happens you can't use the app, meaning the dev experience is completely blocked.

In addition I am seeing this require cycle:

 WARN  Require cycle: index.js -> src/App.js -> src/Expensify.js -> src/libs/Notification/PushNotification/subscribePushNotification/index.js -> src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js -> index.js
@hannojg hannojg mentioned this issue Oct 24, 2023
59 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot changed the title DEV: Require cycle causing error "Cannot read property 'REPORT_COMMENT' of undefined" [HOLD for payment 2023-11-02] DEV: Require cycle causing error "Cannot read property 'REPORT_COMMENT' of undefined" Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant