[HOLD for payment 2023-11-01] [HOLD for payment 2023-10-31] Fix the double message on the iou report when we pay a money request using wallet

[techievivek]

Coming from : https://expensify.slack.com/archives/C01GTK53T8Q/p1697796531033319?thread_ts=1697788964.150409&cid=C01GTK53T8Q

Action Performed:

Pre-requisite

• UserA needs to be on the silver wallet.
• UserB needs to be on the gold wallet.

1. As userA request money from userB.
2. As userB pay userA.
3. Check the IOU report from both users end and confirm we only see a single system message.

Expected Result:

We should see a single message that the user needs to update their wallet.

Actual Result:

We're seeing two system messages asking the user to update their wallet and bank account.

CC @trjExpensify @kevinksullivan

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

@techievivek you're putting a PR up for this yeah?

[techievivek]

Yes, I have added the PR, I have a quick question for @situchan

[trjExpensify]

Perfect!

[techievivek]

This is the updated PR for fixing the settled message issues that we saw in the original GH: #30112

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Internal QA] Skip rendering content for pay action on non-send money flow #30079
• [CP stag]Skip rendering IOU pay action for non-send money flow if the user needs to enable wallet or add bank account #30112

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP stag]Skip rendering IOU pay action for non-send money flow if the user needs to enable wallet or add bank account #30112

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Checklist time! Bump, @situchan.

[trjExpensify]

Same, awaiting the checklist from @situchan Melv.

[melvin-bot]

@trjExpensify, @techievivek, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

As wallet feature is in beta, yet to add regression test case.

[trjExpensify]

So payment here is $500 to @situchan for the C+ review of the internal PR.

[trjExpensify]

Q on the regression for wallet on another issue.

[trjExpensify]

Sent you an offer :)

[trjExpensify]

Paid!