Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-20] Payment issue for E/App PR#26219 #28855

Closed
melvin-bot bot opened this issue Oct 4, 2023 · 11 comments
Closed

[HOLD for payment 2023-10-20] Payment issue for E/App PR#26219 #28855

melvin-bot bot opened this issue Oct 4, 2023 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Issue created to compensate the Contributor+ member for their work on #26219
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/295255.
Contributor+ member who reviewed the PR - @mananjadhav.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013be321a720cd6566
  • Upwork Job ID: 1709658015684608000
  • Last Price Increase: 2023-10-04
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Oct 4, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Oct 4, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013be321a720cd6566

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 4, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 4, 2023

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@sakluger
Copy link
Contributor

sakluger commented Oct 4, 2023

This issue has not been deployed yet, moving to Weekly.

@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Oct 4, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 11, 2023
@sakluger
Copy link
Contributor

Not 100% sure what's going on with #26219. It looks like it was associated wth a deploy blocker, I'll comment in the PR to see how I should handle payment.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@sakluger
Copy link
Contributor

The fix for the regression was deployed on Friday, so payment can be made this upcoming Friday, Oct 20. I closed the Upwork job that was automatically created since @mananjadhav is eligible to get paid via Manual Request. I'll add the payout summary before friday 👍

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@sakluger sakluger changed the title Payment issue for E/App PR#26219 [HOLD for payment 2023-10-20] Payment issue for E/App PR#26219 Oct 16, 2023
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Oct 16, 2023
@sakluger
Copy link
Contributor

Because there was a regression, we will be reducing pay on this review by 50%. The original payment amount was $500, so the new payment amount will be $250.

@mananjadhav
Copy link
Collaborator

@sakluger I am raising a request on NewDot for this one?

@JmillsExpensify
Copy link

$250 payment approved for @mananjadhav based on summary above.

@sakluger
Copy link
Contributor

I am raising a request on NewDot for this one?

Yes, that's correct. Thanks @JmillsExpensify for approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants