[HOLD for payment 2023-11-02] [$500] Chat - Can't open context menu by long press on mentions

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Send a mention in chat
3. Long press on mention
4. Observe context menu doesn't popup

Expected Result:

The context menu should popup using long press on mention.

Actual Result:

The context menu does not popup using long press on mention.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-09-20.at.12.21.47.mp4

Screen_Recording_20230921_101213_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695192996432379

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0154277460b139401d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[kbecciv]

Proposal by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695192996432379

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Can't open context menu by long press on mentions.

What is the root cause of that problem?

We are not using PressableWithSecondaryInteraction or PressableWithoutFeedback with ShowContextMenuContext.Consumer for MentionUserRenderer.

What changes do you think we should make in order to solve the problem?

We need to use PressableWithSecondaryInteraction or PressableWithoutFeedback with ShowContextMenuContext.Consumer for MentionUserRenderer component and instead of using TextLink we need to use Text component and move proponPress to PressableWithSecondaryInteraction.

Result:

fix_demo.mp4

[fedirjh]

cc @MitchExpensify This doesn’t looks like a bug to me. What context menu should be opened for mention ?

[MitchExpensify]

I agree @fedirjh , I'm not sure what context menu is being referred to here. Closing!

[Krishna2323]

@fedirjh @MitchExpensify, I'm taking about the menu which holds emoji reactions, copy to clipboard, reply in thread & other options and it does work on all other elements except mentions.

WhatsApp.Video.2023-09-25.at.17.31.37.mp4

[fedirjh]

@Krishna2323 The context menu should be opened for the entire comment. However, you clicked on the mention link. For instance, links and emails have their context menu opened when you long-press on an email or link. It does not open the context menu for the comment.

CleanShot.2023-09-25.at.18.07.57.mp4

[Krishna2323]

@fedirjh, that's correct but mentions does not have it's own context menu so it should open the comment's context menu, we can take images as an example, even though it has its own route it still opens the context menu by long pressing on it.

[Krishna2323]

@fedirjh, friendly bump.

[Krishna2323]

@MitchExpensify @fedirjh, can you pls take a look here, on mWeb I'm able to open context menu by long pressing on Mentions but not on the native app.

WhatsApp.Video.2023-10-02.at.15.41.15.mp4

[MitchExpensify]

Thanks for following up! I also reproduced this like you described

[MitchExpensify]

Clarifying what is expected here https://expensify.slack.com/archives/C03U7DCU4/p1696285400796969

[MitchExpensify]

Confirmed long press on mentions should open the comment action menu

[Krishna2323]

@fedirjh, bump for proposal review.

[melvin-bot]

@MitchExpensify @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Krishna2323]

@fedirjh, PR ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Chat - Can't open context menu by long press on mentions. #29648

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment
• @Krishna2323 requires payment
• @Krishna2323 requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: [No QA] create UserMentionRenderer for rendering mentions inside chat #18495
• Link to comment: [No QA] create UserMentionRenderer for rendering mentions inside chat #18495 (comment)
• Link to discussion: N/A nothing to add to checklist.
• Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Open App
2. Open any report
3. Send a mention in chat
4. Long press/Right-click on mention
5. Verify the comment context menu opens

• Do we agree 👍 or 👎

[Krishna2323]

@MitchExpensify, bump for payments here.

[MitchExpensify]

Payment summary:

$500 @fedirjh requires payment
$550 @Krishna2323 requires payment

[MitchExpensify]

New Upwork Job created for payment: https://www.upwork.com/jobs/~01cc618434de8e0915

[MitchExpensify]

Offers sent, lemme know when you accept them! Thanks

[Krishna2323]

@MitchExpensify, accepted.

[fedirjh]

@MitchExpensify Thank you. Accepted.

[MitchExpensify]

Paid and contracts ended!

[MitchExpensify]

Tests added! Thanks, everyone