Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-12-08] [$500] Improvements to private notes #27634

Closed
techievivek opened this issue Sep 18, 2023 · 57 comments
Closed

[HOLD for payment 2023-12-08] [$500] Improvements to private notes #27634

techievivek opened this issue Sep 18, 2023 · 57 comments
Assignees
@michaelhaxhiu @ArekChr @techievivek @DylanDylann
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@techievivek
Copy link
Contributor

techievivek commented Sep 18, 2023 •
edited by melvin-bot bot
Loading

Adding a few improvements that we can do to the private notes feature on newDot.

  • Fix the navigation flow for private notes.

Coming from this convo on slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1696267952975749?thread_ts=1696266142.168929&cid=C01GTK53T8Q, we want to update the navigation flow for the private notes feature. This is how the updated navigation would look like.

image
image

  • In the implementation PR, we used an existing style for the multi-line input text area. However, since private notes tend to be longer in content, it would be better to increase the height of the editor area to make it more user-friendly.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d84b43e3b811080f
  • Upwork Job ID: 1703639971803459584
  • Last Price Increase: 2023-11-08
  • Automatic offers:
    • DylanDylann | Contributor | 27643291
@techievivek techievivek added Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Sep 18, 2023
@techievivek techievivek self-assigned this Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d84b43e3b811080f

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ArekChr (Internal)

@techievivek
Copy link
Contributor Author

I worked on the original implementation issue so I will work on the improvements as well.

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@ArekChr, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@techievivek techievivek added the Reviewing Has a PR in review label Sep 25, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@techievivek techievivek mentioned this issue Sep 25, 2023
Closed
59 tasks
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@ArekChr, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@ArekChr, @techievivek Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@ArekChr, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@ArekChr, @techievivek 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@ArekChr, @techievivek 12 days overdue now... This issue's end is nigh!

@ArekChr
Copy link
Contributor

ArekChr commented Oct 12, 2023

@techievivek any update on this PR?

@techievivek
Copy link
Contributor Author

Sorry, I will keep this on HOLD for just a few more days due to some other higher priority works in the pipeline.

@trjExpensify
Copy link
Contributor

trjExpensify commented Oct 16, 2023 •
edited
Loading

👋 Coming from the slack convo with @shawnborton the other day, here's where I believe we landed:

image
image

@shawnborton
Copy link
Contributor

Looks right to me.

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@ArekChr, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

@ArekChr, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@techievivek techievivek removed the Internal Requires API changes or must be handled by Expensify staff label Oct 25, 2023
@techievivek
Copy link
Contributor Author

Going to pass it to a contributor.

@techievivek techievivek added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors and removed Reviewing Has a PR in review labels Oct 25, 2023
@melvin-bot melvin-bot bot changed the title Improvements to private notes [$500] Improvements to private notes Oct 25, 2023
@DylanDylann DylanDylann mentioned this issue Nov 15, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 15, 2023
@DylanDylann
Copy link
Contributor

@ArekChr PR #31344 is ready to review

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 30, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 1, 2023
@melvin-bot melvin-bot bot changed the title [$500] Improvements to private notes [HOLD for payment 2023-12-08] [$500] Improvements to private notes Dec 1, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 1, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 1, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 8, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 11, 2023

@ArekChr, @techievivek, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@techievivek
Copy link
Contributor Author

Adding a BZ member to help us with the payment here.

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@techievivek techievivek added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 11, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot

This comment was marked as outdated.

Sign in to view
@techievivek
Copy link
Contributor Author

@michaelhaxhiu Added you to GH to help us with the payments here, thanks. 🙇

@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2023
@techievivek
Copy link
Contributor Author

Not overdue, gentle bump @michaelhaxhiu

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
@michaelhaxhiu
Copy link
Contributor

working on it

@michaelhaxhiu
Copy link
Contributor

Paid, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelhaxhiu michaelhaxhiu

@ArekChr ArekChr

@techievivek techievivek

@DylanDylann DylanDylann

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@shawnborton @michaelhaxhiu @trjExpensify @hungvu193 @ArekChr @techievivek @DylanDylann