[PAID] [$500] help.expensify.com is showing broken "Not found page"

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to help.expensify.com/abcd
2. Notice that there is overlapped not found text and broken image

Expected Result:

Should show correct image and text without any overlapping

Actual Result:

Shows overlapped text with broken image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.69-0
Reproducible in staging?: n/a
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.at.18.17.16.mov

Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692796609530559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155f0466612861fa0
• Upwork Job ID: 1702163572248096768
• Last Price Increase: 2023-09-14

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mvtglobally]

Proposal

Please re-state the problem that we are trying to solve in this issue.

help.expensify.com is showing broken "Not found page"

What is the root cause of that problem?

The image is broken because wrong image is being pointed to

App/docs/404.html

Line 5 in 867d61e

<img class="icon" src="/assets/images/hourglass.svg" />

the existing file is called circle-hourglass
The overlapping is happening because centered-content class has position: absolute

App/docs/_sass/_main.scss

Lines 566 to 570 in 867d61e

	.centered-content {
	height: 240px;
	text-align: center;
	font-size: larger;
	position: absolute;

What changes do you think we should make in order to solve the problem?

We should fix src of image to point to correct image.
I am assuming the whole page should just show Hmm it's not here... and when scrolled down the footer should appear, but we can clarify exact design with responsible person.
To achieve above mentioned case we just need to modify centered-content with something like this:

    width: 100%;
    height: calc(100vh - 56px);
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
    text-align: center;

The result:

https://github.com/Expensify/App/assets/59907218/0d86c098-4247-49fa-8b7d-4eb05f384ec2

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155f0466612861fa0

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[mvtglobally]

From Original contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

help.expensify.com is showing broken "Not found page"

What is the root cause of that problem?

The image is broken because wrong image is being pointed to

App/docs/404.html

Line 5 in 867d61e

<img class="icon" src="/assets/images/hourglass.svg" />

the existing file is called circle-hourglass
The overlapping is happening because centered-content class has position: absolute

App/docs/_sass/_main.scss

Lines 566 to 570 in 867d61e

	.centered-content {
	height: 240px;
	text-align: center;
	font-size: larger;
	position: absolute;

What changes do you think we should make in order to solve the problem?

We should fix src of image to point to correct image.
I am assuming the whole page should just show Hmm it's not here... and when scrolled down the footer should appear, but we can clarify exact design with responsible person.
To achieve above mentioned case we just need to modify centered-content with something like this:

    width: 100%;
    height: calc(100vh - 56px);
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
    text-align: center;

The result:

https://github.com/Expensify/App/assets/59907218/0d86c098-4247-49fa-8b7d-4eb05f384ec2

What alternative solutions did you explore? (Optional)

[strepanier03]

Able to repro, will follow along.

[melvin-bot]

@strepanier03, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertKozik]

Sorry for keeping you waiting @alitoshmatov ! I assume you are the author of the proposal. I've managed to check it and it does the job. Let's proceed with it

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

Agreed, it looks like @alitoshmatov submitted the proposal in slack & it looks good, assigning 👍

[Beamanator]

Oh I can't assign you @alitoshmatov until you comment in this issue 😬

[alitoshmatov]

@Beamanator 👋

[melvin-bot]

❌ There was an error making the offer to @alitoshmatov for the Contributor role. The BZ member will need to manually hire the contributor. cc @thienlnam

[melvin-bot]

❌ There was an error making the offer to @alitoshmatov for the Reporter role. The BZ member will need to manually hire the contributor. cc @thienlnam

[alitoshmatov]

Pr is ready - #27839

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Docs: 404 page #27839

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @alitoshmatov - $50
• Contributor that fixed the issue - @alitoshmatov - $500
• Contributor+ that helped on the issue and/or PR - N/A

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment
• @robertKozik does not require payment (Contractor)
• @alitoshmatov requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@alitoshmatov - I have hired you in Upwork and will pay when you accept the job. I made one contract for both reporting and contributing and will apply a bonus for the reporting job.

Thanks!

[alitoshmatov]

@strepanier03 Accepted

[alitoshmatov]

@strepanier03 Friendly bump on payment

[Beamanator]

Can this be closed? Or not quite yet?

[alitoshmatov]

I have received payment yet

[strepanier03]

@alitoshmatov - I've paid both payments and closed the contract, thanks for your patience there was a lot on my plate to get through.

---

@Beamanator - Unless there's something I'm not aware of that means we don't need it, we're waiting on the BZ checklist responses from @robertKozik and then I can make a regression if needed and close this GH.

[robertKozik]

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Core Branding Add New Icons #12796
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12796/files#r1361708247
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I think it's not needed here
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[strepanier03]

Thank you @robertKozik - Looks like we're all set to close since no regression test is needed.

Cheers everyone!