-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Asking sign-in again from public room after refresh #27198
Comments
Triggered auto assignment to @strepanier03 ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~015c546ad4cf74de6e |
Triggered auto assignment to @sophiepintoraetz ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
In the QA video, they were not able to sign in due to an invalid magic code. Is that the issue? |
Seems like a regression. |
ProposalPlease re-state the problem that we are trying to solve in this issue.If the user signs in while viewing an anonymous report, the authentication state is not persisted. What is the root cause of that problem?Once the user opens a public room without having been signed in, they are signed in as an anonymous user. This information is retained in Oryx in the This should be cleared once the server returns a log in response with However, Onyx fails to persist this to the disk. The The application therefore believes that the current user is an anonymous user. Onyx's failure arises as follows:
What changes do you think we should make in order to solve the problem?Because the What alternative solutions did you explore? (Optional)Instead of using Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
📣 @saraelsa! 📣
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Thanks, @saraelsa for the proposal. As you mentioned, this is a regression from Recent Onyx changes. We are actively making changes to Onyx ATM. I think it will be better to let that team handle that issue. If we find that some changes are required on app side, we can revisit the proposals here. |
Thanks @parasharrajat - In that case do you recommend closing this or leaving it open but not accepting proposals? |
@sophiepintoraetz - Looks like a double assignment so I'm going to remove you so you don't have to worry about this. |
@strepanier03 It would be better if someone from internal team confirms that same and plans the next action before we close it. |
Gotcha, thanks @parasharrajat - I'm raising internally now. |
@strepanier03, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Waiting on internal decision @strepanier03 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Bumped internally again. |
@parasharrajat - Can you tell me who the people are that are working on these Onyx changes you mention? I've asked a few times in Slack and no one can point me in the right direction. |
Even I don't know. I will find them and tag here. |
@strepanier03 Tagged. |
Thank you! |
@strepanier03 @parasharrajat this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@izarutskaya @b4s36t4 is it still reproducible? |
@parasharrajat Yes it still re-produceable took a latest pull and tested. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Coming from here, assigning myself. @daordonez11 mentioned that we're still getting the value for |
Thank you @marcochavezf - I'll follow along but ping me if you need me to do something I'm not doing 🙌 |
I think this dube of this #26615 (comment) @marcochavezf this onyx issue. api is giving null only but onyx not removing the key |
Hi @pradeepmdk, I saw your comment here, do you know by chance if that also impacts this issue? |
This comment was marked as outdated.
This comment was marked as outdated.
@marcochavezf yes, this is fixed now. you can verify this one staging now. Untitled.mp4 |
@marcochavezf @strepanier03 @parasharrajat this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@marcochavezf, @strepanier03, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Oh cool, @strepanier03 I think we can then close this one |
Sounds good, I'll do that now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Once after login it shouldn't ask login again.
Actual Result:
Asking login again.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.67-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Kapture.2023-09-06.at.14.15.52.mp4
Recording.1505.mp4
Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693989869553719
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: