[HOLD for payment 2023-10-12] [$500] Chat - Space is not added after an emoji is selected

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #24614

Action Performed:

1. Launch New Expensify app
2. Go to any chat
3. Open emoji picker
4. Select an emoji
5. Add another emoji

Expected Result:

Space is added after an emoji is selected

Actual Result:

Space is not added after an emoji is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188282_Screen_Recording_20230905_013226_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d9f65ce9e5e54e44
• Upwork Job ID: 1699517068377264128
• Last Price Increase: 2023-09-20
• Automatic offers:
• jjcoffee | Reviewer | 26895645
• Krishna2323 | Contributor | 26895646

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[napster125]

I can't reproduce it.

[joelbettner]

I also cannot reproduce. I've tried to reproduce on desktop, mobile and web, too.

[kavimuru]

@joelbettner Reproducible only in Android app.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Thanks not a blocker

[napster125]

@kavimuru I can't reproduce on Android native.

[johncschuster]

@joelbettner are we good to close this one since it seems we can't reproduce it?

[joelbettner]

@lanitochka17 are you still able to reproduce this? If not, let's go ahead and close, otherwise, @johncschuster let's open it for an external contributor to work on.

[lanitochka17]

Issue reproducible on the latest version (v1.3.64-0)
Samsung Galaxy Note 10+ / Android 12

Screen_Recording_20230906_120740_New.Expensify.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d9f65ce9e5e54e44

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Space is not added after an emoji is selected

What is the root cause of that problem?

We're adding space after clicking the emoji, the issue is that we're moving the selection cursor the point later to the space.

We're calculating the selection position based on the text (which is before adding the space).

Here

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Lines 263 to 267 in 1223e1e

	setSelection((prevSelection) => ({
	start: prevSelection.start + text.length + selectionSpaceLength,
	end: prevSelection.start + text.length + selectionSpaceLength,
	}));
	},

is the code that is causing the issue.

What changes do you think we should make in order to solve the problem?

We should update text.length to updatedText.length to move the cursor to after space.

What alternative solutions did you explore? (Optional)

NA

[Krishna2323]

@jjcoffee, PR is ready for a review :)

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Krishna2323 got assigned: 2023-09-27 00:07:59 Z
• when the PR got merged: 2023-10-03 02:04:36 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Chat - Space is not added after an emoji is selecte #28302

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment offer (Reviewer)
• @Krishna2323 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

Just noting this one was C+ approved within 3 WD, and merged without any changes requested later (due to engineer delay), so I think this one is still due the urgency bonus.

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: fix: 24261 user able to select 2 emoji at a time #24614
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: 24261 user able to select 2 emoji at a time #24614 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this one would be too hard to catch I think!
• Determine if we should create a regression test for this bug. Yes - easy enough to test
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. See below

[jjcoffee]

Regression Test Proposal

1. Go to any chat
2. Open the emoji picker
3. Select any emoji
4. Verify that the emoji is inserted with a single space following it

Do we agree 👍 or 👎

[joelbettner]

@johncschuster has the payment been finished for this?

What do we need to do to get this issue closed?

[Krishna2323]

@johncschuster, bump for payments.

[johncschuster]

Ah, sorry this was held on me! I'll get payment issued!

[johncschuster]

Payment has been issued!