-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] IOU Distance - Save button in waypoint editor is not responsive #26286
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @Li357 ( |
ProposalPlease state again the problem we are trying to solve in this issue.IOU Distance - Save button in waypoint editor is not responsive. What is the cause of this issue?If we clear the address field and save, App/src/pages/iou/WaypointEditor.js Lines 120 to 123 in 01d0d3b
In Transaction.removeWaypoint , we call saveWaypoint with null of waypoint .App/src/libs/actions/Transaction.js Line 113 in 01d0d3b
Therefore, the following code throws an error, and then app will be unresponsive. App/src/libs/actions/Transaction.js Line 96 in 01d0d3b
What changes do you think we should make to solve the problem?We can return if + if (!waypoint) {
+ return;
+ }
const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address); What alternative solutions have you investigated? (Optional)None. |
I have reported this bug earlier. cc: @hayata-suenaga |
I'm taking this over since it's a distance bug. Actually maybe the person who introduced this should take it if they are online. |
I commented on the PR that caused this regression. We're discussing internally about having a contributor fix this in a PR that's in progress. |
The cause was identified and being fixed in the PR Neil mentioned above |
Also not a blocker because it's under a beta |
@neil-marcellini Still overdue 6 days?! Let's take care of this! |
1 similar comment
@neil-marcellini Still overdue 6 days?! Let's take care of this! |
@neil-marcellini Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@neil-marcellini 10 days overdue. I'm getting more depressed than Marvin. |
This issue has not been updated in over 14 days. @neil-marcellini eroding to Weekly issue. |
This was fixed long ago. Idk where but that's ok. |
Oh wait maybe we need to pay the reporting bonus. I'll assign BZ to do that. |
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~016b55cf7fbb4a3cad |
📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@b4s36t4 can you please apply for the Reporter Role on Upwork? I'll take care of the reporting bonus after you've done that. |
@johncschuster above offer is for Contributor role mistakenly I have accepted it. |
What do I do? |
@b4s36t4 No worries. I'll edit it on my end. |
@b4s36t4 I've manually invited you to a different contract with the Bug Reporter rate. Can you accept that please? |
@johncschuster Accepted new offer. Thanks :) |
Payment has been issued! Thanks, @b4s36t4! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #25984
Action Performed:
Expected Result:
User is redirected to Distance page
Actual Result:
User is not redirected to Distance page. Save button is not responsive
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6182644_20230830_202346.mp4
Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: