[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282

izarutskaya · 2023-08-30T13:18:46Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on FAB
Click Save the World > I am a teacher
Click on the Update email address button
Refresh page.
Click on the back button

Expected Result:

Clicking back takes you to the 'I am a teacher' page

Actual Result:

Clicking back take you to profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.59-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T139backbutton-1.mp4

Recording.1382.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693399672874879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e00165b404e4216b
Upwork Job ID: 1696904936518942720
Last Price Increase: 2023-10-30
Automatic offers:

jjcoffee | Reviewer | 27440202
paultsimura | Contributor | 27440206
daveSeife | Reporter | 27440209

Issue Owner

Current Issue Owner: @trjExpensify

melvin-bot · 2023-08-30T13:18:51Z

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-30T13:18:53Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-08-30T13:20:21Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-08-30T13:20:25Z

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

paultsimura · 2023-08-30T14:03:44Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

After refreshing a page on "I am a teacher > Update email" drawer, the "Go Back" button returns to Profile settings

What is the root cause of that problem?

On refresh, the navigation has no information about the previous page, so the goBack function navigates to the fallback route: ROUTES.SETTINGS_PROFILE

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.js

Line 117 in d8b9cdd

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PROFILE)}

What changes do you think we should make in order to solve the problem?

Pass a URL parameter backTo while opening the "Edit Email" page, and use it as a fallback route for the "Go back" button:

const navigateBackTo = lodashGet(props.route, 'params.backTo', '');
...
<HeaderWithBackButton
                ...
                onBackButtonPress={() => Navigation.goBack(navigateBackTo)}
            />

What alternative solutions did you explore? (Optional)

conorpendergrast · 2023-08-30T14:18:18Z

FYI @youssef-lr @StefStavri

I don't think this needs to be an Hourly or Deploy Blocker because this is a beta feature that's part of wave7. I'll change those labels now, but change them back if you disagree!

conorpendergrast · 2023-08-30T14:20:09Z

I've also cross-posted to our internal channel for this project to make sure that's correct

youssef-lr · 2023-08-30T14:59:28Z

@dhairyasenjaliya could you look into this please?

youssef-lr · 2023-08-30T15:11:23Z

~~I'm unable to reproduce this..~~

I was able to reproduce, @dhairyasenjaliya if you're around take a look please?

conorpendergrast · 2023-08-30T15:12:41Z

I was able to reproduce this:

2023-08-30_16-08-06.mp4

melvin-bot · 2023-10-30T08:50:14Z

Current assignee @dangrous is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2023-10-30T16:01:15Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

dangrous · 2023-10-30T16:31:07Z

Great, let's do it.

melvin-bot · 2023-10-30T16:31:20Z

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-30T16:31:24Z

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-30T16:31:28Z

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

paultsimura · 2023-10-30T20:16:49Z

Thank you all, the PR is ready for review.

paultsimura · 2023-11-13T15:03:07Z

@dangrous the PR is in production already (there was some weird flow: deployed to staging - prod - staging), but the automation didn't update the [HOLD for payment] title, could you please check? 🙏

dangrous · 2023-11-13T20:29:50Z

So that production part is messed up, it's currently only on staging. We should get the right automated message when it's REALLY on production, hopefully!

paultsimura · 2023-11-15T17:01:52Z

@dangrous it was deployed to prod yesterday: #30608 (comment), but the automation did not work still.

dangrous · 2023-11-15T18:46:37Z

hrm, you're right - I'll update the title but I'll see if I can get the rest of them to run again (e.g. checklist, etc.)

dangrous · 2023-11-16T19:57:09Z

Okay so no way to get it automatically, annoyingly. @trjExpensify just be aware that we'll have to figure out who needs what at the end of this. I believe it will be @paultsimura as contributor, @jjcoffee as C+, @daveSeife as reporter

And, copying the checklist here:

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

jjcoffee · 2023-11-17T09:34:49Z

The PR that introduced the bug has been identified. Link to the PR: N/A - a fallback route was never provided
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes - easy enough to test
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open FAB and go to Save the World -> I am a teacher
Click on the Update email address button
Refresh page
Click on the back button
Verify that you are taken back to the previous screen (i.e. the 'I am a teacher' page)

Do we agree 👍 or 👎

jjcoffee · 2023-11-22T16:44:07Z

Friendly bump for payment @trjExpensify 🙇

trjExpensify · 2023-11-22T17:56:26Z

Okay, so this is fun!

Grandfathered base rates on this as the issue was created before the cut off on August 30th with the first change.
No #urgency bonus because the PR was created on Oct 30th, after the second program change to remove that on Oct 24th.

By my calculations then:

$250 to @daveSeife for the bug report
$1000 to @jjcoffee for the C+ review
$1000 to @paultsimura for the bug fix

As for the regression test. It seems a bit niche in isolation, IMO. Though, @JmillsExpensify @marcochavezf as part of the STW doc wrap-up, have tests been given to Applause for the core flow? Marco, I know you were looking at pointing to a test policy to allow for testing at some point?

trjExpensify · 2023-11-22T17:57:09Z

@jjcoffee @dangrous let me know if you agree on the payouts and I'll action on settling up.

dangrous · 2023-11-22T19:00:52Z

I think that's right!

jjcoffee · 2023-11-23T07:32:43Z

@trjExpensify Yup, I'm good with that!

trjExpensify · 2023-11-23T16:29:10Z

Perfect. Settled up with all three of you. Closing, thanks!

marcochavezf · 2023-11-23T18:59:51Z

I know you were looking at pointing to a test policy to allow for testing at some point?

Yeah, this is the GH for the QA tests, but we're still figuring out how to flip the policyID and public room reportID for testing.

trjExpensify · 2023-11-23T19:15:30Z

Cool, thanks!

melvin-bot · 2024-03-14T14:10:16Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 30, 2023

melvin-bot bot assigned conorpendergrast Aug 30, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 30, 2023

OSBotify mentioned this issue Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

melvin-bot bot assigned dangrous Aug 30, 2023

conorpendergrast changed the title ~~FAB - Clicking back button on the 'I am a teacher' page does not take you back to the previous page~~ FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page Aug 30, 2023

conorpendergrast added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Aug 30, 2023

StefStavri added Hourly KSv2 and removed Daily KSv2 labels Aug 30, 2023

conorpendergrast added the DeployBlockerCash This issue or pull request should block deployment label Aug 30, 2023

dangrous assigned paultsimura Oct 30, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 30, 2023

paultsimura mentioned this issue Oct 30, 2023

fix: goBack from 'I am a teacher' contact methods #30608

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 30, 2023

trjExpensify closed this as completed Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282

[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282

izarutskaya commented Aug 30, 2023 •

edited by dangrous

Loading

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023 •

edited by conorpendergrast

Loading

OSBotify commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

paultsimura commented Aug 30, 2023

conorpendergrast commented Aug 30, 2023

conorpendergrast commented Aug 30, 2023

youssef-lr commented Aug 30, 2023

youssef-lr commented Aug 30, 2023 •

edited

Loading

conorpendergrast commented Aug 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

dangrous commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

paultsimura commented Oct 30, 2023

paultsimura commented Nov 13, 2023

dangrous commented Nov 13, 2023

paultsimura commented Nov 15, 2023

dangrous commented Nov 15, 2023

dangrous commented Nov 16, 2023

jjcoffee commented Nov 17, 2023

jjcoffee commented Nov 22, 2023

trjExpensify commented Nov 22, 2023

trjExpensify commented Nov 22, 2023

dangrous commented Nov 22, 2023

jjcoffee commented Nov 23, 2023

trjExpensify commented Nov 23, 2023

marcochavezf commented Nov 23, 2023

trjExpensify commented Nov 23, 2023

melvin-bot bot commented Mar 14, 2024

[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282

[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page #26282

Comments

izarutskaya commented Aug 30, 2023 • edited by dangrous Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023 • edited by conorpendergrast Loading

Bug0 Triage Checklist (Main S/O)

OSBotify commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

paultsimura commented Aug 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

conorpendergrast commented Aug 30, 2023

conorpendergrast commented Aug 30, 2023

youssef-lr commented Aug 30, 2023

youssef-lr commented Aug 30, 2023 • edited Loading

conorpendergrast commented Aug 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

dangrous commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

melvin-bot bot commented Oct 30, 2023

paultsimura commented Oct 30, 2023

paultsimura commented Nov 13, 2023

dangrous commented Nov 13, 2023

paultsimura commented Nov 15, 2023

dangrous commented Nov 15, 2023

dangrous commented Nov 16, 2023

jjcoffee commented Nov 17, 2023

jjcoffee commented Nov 22, 2023

trjExpensify commented Nov 22, 2023

trjExpensify commented Nov 22, 2023

dangrous commented Nov 22, 2023

jjcoffee commented Nov 23, 2023

trjExpensify commented Nov 23, 2023

marcochavezf commented Nov 23, 2023

trjExpensify commented Nov 23, 2023

melvin-bot bot commented Mar 14, 2024

izarutskaya commented Aug 30, 2023 •

edited by dangrous

Loading

melvin-bot bot commented Aug 30, 2023 •

edited by conorpendergrast

Loading

youssef-lr commented Aug 30, 2023 •

edited

Loading