[HOLD for payment 2024-02-26] [$250] [TS migration] Migrate 'SignIn' page to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/signin/UnlinkLoginForm.js	19
src/pages/signin/Terms.js	6
src/pages/signin/Socials.js	11
src/pages/signin/SignInPageHero.js	8
src/pages/signin/SignInPage.js	21
src/pages/signin/SignInHeroImage.js	6
src/pages/signin/SignInHeroCopy.js	9
src/pages/signin/LoginForm.js	31
src/pages/signin/Licenses.js	8
src/pages/signin/EmailDeliveryFailurePage.js	14
src/pages/signin/ChangeExpensifyLoginLink.js	12
src/pages/signin/SignInPageLayout/index.js	18
src/pages/signin/SignInPageLayout/SignInPageContent.js	15
src/pages/signin/SignInPageLayout/Footer.js	20
src/pages/signin/SignInPageLayout/signInPageStyles/index.native.js	1
src/pages/signin/SignInPageLayout/signInPageStyles/index.js	1
src/pages/signin/SignInPageLayout/BackgroundImage/index.js	5
src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js	1

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f3d6aa7b7ed48f51
• Upwork Job ID: 1750844156011888640
• Last Price Increase: 2024-01-26
• Automatic offers:
• s77rt | Reviewer | 28123486
• fedirjh | Contributor | 28123487

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[fabioh8010]

Updated List

Files

Path	Dependencies
src/pages/signin/UnlinkLoginForm.js	19
src/pages/signin/ThirdPartySignInPage.js	18
src/pages/signin/Socials.js	11
src/pages/signin/SignInPageHero.js	9
src/pages/signin/SignInPage.js	28
src/pages/signin/SignInModal.js	7
src/pages/signin/SignInHeroImage.js	7
src/pages/signin/SignInHeroCopy.js	10
src/pages/signin/Licenses.js	8
src/pages/signin/EmailDeliveryFailurePage.js	14
src/pages/signin/ChooseSSOOrMagicCode.js	20
src/pages/signin/SignInPageLayout/index.js	18
src/pages/signin/SignInPageLayout/SignInPageContent.js	15
src/pages/signin/SignInPageLayout/Footer.js	18
src/pages/signin/SignInPageLayout/signInPageStyles/index.native.js	1
src/pages/signin/SignInPageLayout/signInPageStyles/index.js	1
src/pages/signin/SignInPageLayout/BackgroundImage/propTypes.js	1
src/pages/signin/SignInPageLayout/BackgroundImage/index.js	6
src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js	4
src/pages/signin/SAMLSignInPage/index.js	13
src/pages/signin/LoginForm/index.native.js	4
src/pages/signin/LoginForm/index.js	3
src/pages/signin/LoginForm/BaseLoginForm.js	36

[s-alves10]

Dibs

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f3d6aa7b7ed48f51

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Upwork job price has been updated to $250

[fedirjh]

cc @mountiny

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[s77rt]

PR still in draft status. @fedirjh do you have an ETA?

[fedirjh]

do you have an ETA?

It should be ready by tomorrow. It's already ready for code review, I just have to complete the PR checklist.

[fedirjh]

cc @s77rt PR is ready for review:

• [TS migration] Migrate Signin to TypeScript #35294

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate Signin to TypeScript #35294

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment automatic offer (Reviewer)
• @fedirjh requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @fedirjh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[s77rt]

Not a NewFeature. No regression test needed

[puneetlath]

Whoops, didn't realize I wasn't the BZ on this one, but I went ahead and paid, so we're good to go here. Thanks y'all!