Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript #25073

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AddPaymentMethodMenu.js 13
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@mateuuszzzzz
Copy link
Contributor

Hi! I will take over this issue from Bartosz. I'm Mateusz Rajski from the Software Mansion expert agency.

Copy link
Author

melvin-bot bot commented Feb 19, 2024

📣 @mateuuszzzzz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link
Author

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 26, 2024
Copy link
Author

melvin-bot bot commented Mar 26, 2024

@MariaHCD
Copy link
Contributor

The PR was merged today. I believe @mananjadhav will need payment for the C+ review.

@adelekennedy
Copy link

adelekennedy commented Mar 26, 2024

payment due in 7 days

@adelekennedy adelekennedy added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 26, 2024
@adelekennedy adelekennedy changed the title [TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript [HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript Mar 26, 2024
@adelekennedy adelekennedy reopened this Mar 26, 2024
@adelekennedy adelekennedy assigned mananjadhav and unassigned MariaHCD Mar 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript [HOLD for payment 2024-04-05] [HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript Mar 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link
Author

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests

Copy link
Author

melvin-bot bot commented Mar 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mananjadhav
Copy link
Collaborator

This was a migration PR, hence the checklist doesn't apply.

@adelekennedy Can you please post the payout summary?

@adelekennedy adelekennedy changed the title [HOLD for payment 2024-04-05] [HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript [HOLD for payment 2024-04-02][TS migration] Migrate 'AddPaymentMethodMenu.js' component to TypeScript Apr 4, 2024
@adelekennedy
Copy link

adelekennedy commented Apr 4, 2024

Payouts due:

@JmillsExpensify
Copy link

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

6 participants