Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-22] [TS migration] Migrate 'ErrorBoundary' component to TypeScript #25043

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ErrorBoundary/index.native.js 3
src/components/ErrorBoundary/index.js 2
src/components/ErrorBoundary/BaseErrorBoundary.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@pasyukevich
Copy link
Contributor

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

Copy link
Author

melvin-bot bot commented Nov 14, 2023

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ErrorBoundary' component to TypeScript [HOLD for payment 2023-11-22] [TS migration] Migrate 'ErrorBoundary' component to TypeScript Nov 15, 2023
Copy link
Author

melvin-bot bot commented Nov 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 15, 2023
Copy link
Author

melvin-bot bot commented Nov 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 22, 2023
Copy link
Author

melvin-bot bot commented Nov 27, 2023

@Li357 Eep! 4 days overdue now. Issues have feelings too...

@Li357
Copy link
Contributor

Li357 commented Nov 27, 2023

@pasyukevich Just checking- no payment here because this is with an expert agency right?

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
Copy link
Author

melvin-bot bot commented Nov 30, 2023

@Li357 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 30, 2023
@pasyukevich
Copy link
Contributor

@Li357 Yes, it is processed separately

Copy link
Author

melvin-bot bot commented Dec 4, 2023

@Li357 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link
Author

melvin-bot bot commented Dec 7, 2023

@Li357 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link
Author

melvin-bot bot commented Dec 11, 2023

@Li357 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

This issue has not been updated in over 14 days. @Li357 eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 8, 2024
Copy link
Author

melvin-bot bot commented Jan 8, 2024

This issue has not been updated in over 15 days. @Li357 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Apr 5, 2024
Copy link
Author

melvin-bot bot commented Apr 5, 2024

@Li357, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

2 participants