[HOLD for payment 2023-12-15] [TS migration] Migrate 'PushNotification' lib to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js	7
src/libs/Notification/PushNotification/shouldShowPushNotification.js	4
src/libs/Notification/PushNotification/index.native.js	9
src/libs/Notification/PushNotification/index.js	1
src/libs/Notification/PushNotification/NotificationType.js	0
src/libs/Notification/PushNotification/configureForegroundNotifications/index.js	0
src/libs/Notification/PushNotification/configureForegroundNotifications/index.ios.js	2
src/libs/Notification/PushNotification/configureForegroundNotifications/index.android.js	2
src/libs/Notification/PushNotification/backgroundRefresh/index.js	0
src/libs/Notification/PushNotification/backgroundRefresh/index.android.js	4

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fvlvte]

I am Kacper Fałat from Callstack - expert contributor group. I'd like to work on this job

[fabioh8010]

Hi, I will take over this one to help split Kacper's work! 🙂

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[fabioh8010]

@fabioh8010

Updated List

Files

Path	Dependencies
src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js	7
src/libs/Notification/PushNotification/shouldShowPushNotification.js	4
src/libs/Notification/PushNotification/index.native.js	9
src/libs/Notification/PushNotification/index.js	1
src/libs/Notification/PushNotification/NotificationType.js	0
src/libs/Notification/PushNotification/subscribePushNotification/index.js	4
src/libs/Notification/PushNotification/backgroundRefresh/index.js	0
src/libs/Notification/PushNotification/backgroundRefresh/index.android.js	6
src/libs/Notification/PushNotification/ForegroundNotifications/index.js	0
src/libs/Notification/PushNotification/ForegroundNotifications/index.ios.js	2
src/libs/Notification/PushNotification/ForegroundNotifications/index.android.js	2

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'PushNotification' lib to TypeScript #32180

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[rlinoz]

Hey @fabioh8010 did the PR fixed all the files in this issue?

[rlinoz]

Hey @burczu should you be assigned to this since you reviewed the PR?

[burczu]

@rlinoz I'm not sure - do we expect BZ Checklist for this kind of task? If so, feel free to assign me.

[fabioh8010]

Hey @fabioh8010 did the PR fixed all the files in this issue?

@rlinoz Yes!

[melvin-bot]

@rlinoz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rlinoz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rlinoz]

@burczu I don't think so, but did you get paid for the C+ review in another issue? If not we probably should do this here.

[burczu]

@rlinoz I'm a contractor from Callstack so I'm not eligible for payment.

[rlinoz]

Oh sorry, I will close the issue then, thanks!