Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'onyxSubscribe.js' lib to TypeScript #24783

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 5 comments
Closed

[TS migration] Migrate 'onyxSubscribe.js' lib to TypeScript #24783

melvin-bot bot opened this issue Aug 16, 2023 · 5 comments

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/onyxSubscribe.js 1
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2023
@JKobrynski
Copy link
Contributor

This issue is on hold as it needs react-native-onyx to be updated (additional types have to be exported)

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant