Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-21] Update App to react-native version 0.72.3 and remove patches #24208

Closed
MonilBhavsar opened this issue Aug 7, 2023 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Aug 7, 2023

Coming from this discussion in slack https://expensify.slack.com/archives/C01GTK53T8Q/p1691377395570339

We upgraded to react-native 0.72.1. There were still some breaking issues and we applied patch for that. Example: #24203

Update react-native to 0.72.3 (latest as of today) and remove the patches

Issue OwnerCurrent Issue Owner: @anmurali
@MonilBhavsar MonilBhavsar added the NewFeature Something to build that is a new item. label Aug 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

@MonilBhavsar MonilBhavsar added the Daily KSv2 label Aug 7, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@MonilBhavsar
Copy link
Contributor Author

Sorry shawn, no design change is required here.

@MonilBhavsar
Copy link
Contributor Author

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 7, 2023
@fabioh8010
Copy link
Contributor

PR is ready: #24224

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 14, 2023
@melvin-bot melvin-bot bot changed the title Update App to react-native version 0.72.3 and remove patches [HOLD for payment 2023-08-21] Update App to react-native version 0.72.3 and remove patches Aug 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Aug 21, 2023
@MonilBhavsar
Copy link
Contributor Author

HOLD on payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2023
@MonilBhavsar
Copy link
Contributor Author

Bumping to weekly. cc @anmurali we need to issue payment here

@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Aug 31, 2023
@anmurali
Copy link

Offer is here @aimane-chnaif

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@MonilBhavsar
Copy link
Contributor Author

@aimane-chnaif are you paid. If so, I think we can close this now

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@aimane-chnaif
Copy link
Contributor

@aimane-chnaif are you paid. If so, I think we can close this now

Contract accepted. Still awaiting approval

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2023
@MonilBhavsar
Copy link
Contributor Author

@anmurali could you please help here to accept the contract

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2023
@MonilBhavsar
Copy link
Contributor Author

Waiting for approval from @anmurali

@melvin-bot melvin-bot bot removed the Overdue label Sep 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@MonilBhavsar
Copy link
Contributor Author

Same ^ cc @anmurali

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2023
@MonilBhavsar
Copy link
Contributor Author

@anmurali 👋

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@anmurali
Copy link

I am confused. I paid this a long time ago
image

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@aimane-chnaif
Copy link
Contributor

I just checked history. Received payment on Oct 3.
Let's close this

@MonilBhavsar
Copy link
Contributor Author

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants