[$1000] [HOLD for payment] 'announce' room disapears from LHN when changing notification setting to 'Mute'

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a workspace
2. Navigate to 'announce' room
3. Click on announce room header
4. Click on 'Settings'
5. Click on 'Daily'
6. Select 'Mute'
7. Select another report from LHN

Expected Result:

announce room shouldn't disappear from LHN

Actual Result:

announce room disappears from LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-18.18-40-59.webm

Recording.1281.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689695228630369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012515a6a4f4f10c96
• Upwork Job ID: 1683427723140796416
• Last Price Increase: 2023-07-24

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

This appears to be intentional in PR #22717

[Nikhil-Vats]

@srikarparsi This would be solved by your revert PR.

[jasperhuangg]

We're discussing here on what the expected behavior is

[jasperhuangg]

We cleared up that this is actually the expected behavior, not a bug, closing

https://expensify.slack.com/archives/C03TQ48KC/p1689709321825069?thread_ts=1689623753.049399&cid=C03TQ48KC

[Natnael-Guchima]

Hello @jasperhuangg, it seems like the PR that has caused this regression is reverted here (Revert "Hide muted chats from LHN"), and the test steps seem to be similar to that I have reported here. This is to check if I am eligible for reporting bonus.
Thanks.

[jasperhuangg]

@laurenreidexpensify I forgot, but let's get @Natnael-Guchima paid out for the reporting bonus

[srikarparsi]

Hey, just want to clarify that we're re-reverting this PR because of miscommunication so hiding announce rooms from the LHN when they are muted is expected behavior. I am good with paying @Natnael-Guchima the reporting bonus as well though since we also thought the same thing but it turns out that this is not a bug.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012515a6a4f4f10c96

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[laurenreidexpensify]

Just added external to get Upwork job up, pls ignore @mollfpr

[laurenreidexpensify]

@Natnael-Guchima offer sent in Upwork

[Natnael-Guchima]

Accepted the offer. Thanks @laurenreidexpensify

[laurenreidexpensify]

Perfect - paid! closing