[$1000] Web - Old Paypal username appears even after deleting

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Paypal page using link https://staging.new.expensify.com/settings/payments/add-paypal-me
2. Add or edit username and click on save button
3. From payments page click on Paypal username and delete it
4. Click on Add payment method button and choose Paypal option

Expected Result:

Old Paypal username should not show

Actual Result:

Old Paypal username appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.42-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-18.at.11.37.56.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689660873381289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01564b9340e7c3d9e9
• Upwork Job ID: 1681650980433195008
• Last Price Increase: 2023-07-19

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

old Paypal username appears even after deleting

What is the root cause of that problem?

When we open add paypal by deep link and confirm to go to the setting payment page, we already have a paypal page in navigation stack. After we delete paypal account and go to add paypal page again, the old paypal page doesn't unmount and then old name is displayed by this page.

What changes do you think we should make in order to solve the problem?

We can use HOC withNavigationFocus and add an useEffect to reset payPalMeUsername state

useEffect(() => {
    setPayPalMeUsername(lodashGet(props.payPalMeData, 'accountData.username', ''))
}, [props.isFocused])

What alternative solutions did you explore? (Optional)

We also can navigate with type UP to remove the paypal page from navigation stack whenever we add or edit paypal

Navigation.navigate(ROUTES.SETTINGS_PAYMENTS, 'UP');

App/src/pages/settings/Payments/AddPayPalMePage.js

Line 61 in ffe659e

Navigation.navigate(ROUTES.SETTINGS_PAYMENTS);

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Do you think this is counted as regression from our previous PR @eVoloshchak, If yes then I can create a PR to fix this one
#22620

[eVoloshchak]

@hungvu193, could you revert the PR and check if the bug is still present?
If not, yeah, let's spin up the PR to fix it

[hungvu193]

@hungvu193, could you revert the PR and check if the bug is still present? If not, yeah, let's spin up the PR to fix it

Just reverted it, it still happened, it seems like a navigation issue more than a regression. I think it's not regression 😄

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Old Paypal username appears even after deleting

What is the root cause of that problem?

After saving user paypal account, we navigate back instead of going back, when accessing from deeplink, the AddPaypalPage is in the background and never unmounted, so the value from TextInput was still there which caused this issue.

What changes do you think we should make in order to solve the problem?

Instead of going back after saving, we can use goBack. Also don't forget to add fallbackroute as ROUTES.SETTINGS_PAYMENTS:

    const setPayPalMeData = useCallback(() => {
        if (!ValidationUtils.isValidPaypalUsername(payPalMeUsername)) {
            setPayPalMeUsernameError(true);
            return;
        }
        setPayPalMeUsernameError(false);
        User.addPaypalMeAddress(payPalMeUsername);

        Growl.show(growlMessageOnSave, CONST.GROWL.SUCCESS, 3000);
     // We should go back instead of navigating.
        Navigation.goBack(ROUTES.SETTINGS_PAYMENTS);
    }, [payPalMeUsername, growlMessageOnSave]);

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01564b9340e7c3d9e9

[kevinksullivan]

Was able to reproduce on staging

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[dukenv0307]

It is fixed in this PR #23086

[sobitneupane]

Issue no longer reproducible.

cc: @kevinksullivan

[kevinksullivan]

Closing out