-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Header Link Style #22641
Comments
Job added to Upwork: https://www.upwork.com/jobs/~010c43c444f0847d77 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 ( |
@shawnborton just double checking here, should only the blue portion be clickable, or the entire line? |
I'd say the entire line. I also wonder if we want to have some :hover feedback here? Like in the very least, the blue part can use our link hover color. |
Would love to get started on this one now that we merged the avatars PR. |
I think that's where we ended up. As I've said before, I don't feel strongly. I don't mind one entire clean blue link line underneath. |
Ah gotcha. I didn't realize that's where we ended. I think it's a bit much given that |
Sorry, maybe I'm confused by the issue. I think only the parent chat should be in blue and I agree with some hover feedback. |
Cool, I think I'm in the same place. I think it's a little confusing to make the entire sub-header blue, because it's actually referencing like two distinct things: the parentReport and the workspace chat. As a result, I think we should just make the parentReport blue, keeping the rest grey. |
Following up on that last comment, can we update how |
This issue has not been updated in over 15 days. @narefyev91, @grgia eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
I still think this should be |
I actually think this is fixed now and should be closed? I also see that a week after I posted my screenshot above a linked PR was merged and deployed, so yeah I think this is done now. @grgia Do you mind confirming and closing this issue? |
All linked PRs are merged and I can't reproduce so I'm closing this out. Someone please re-open if anything remains. |
Requirements:
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: