Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group - Username B is not updated when user A searches for it via New Group #22503

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 8, 2023 · 8 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #22246

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Open the app and log in with user A
  3. Open the app on another device and log in with user B
  4. Change username B
  5. On user A's device, click on the 'Plus' icon, select 'New group', search for user B

Expected Result:

Changes to username B should be visible to user A

Actual Result:

Username B is not updated when user A searches for it via New Group

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2793.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jeet-dhandha
Copy link
Contributor

This was meant to be, until you have added the User A to the chat and received a message from the User A, the group list won't have its name.

@johncschuster
Copy link
Contributor

Thanks for calling that out, @jeet-dhandha! Are you able to point out where we made that behavior intended? I believe you're right, but pointing to where we intended it would be ace!

@jeet-dhandha
Copy link
Contributor

jeet-dhandha commented Jul 11, 2023

@johncschuster - This is mostly done on backend when User A first message's to the User B then the User A's login will be added to login key of report and thus will show up in Search List for Group.

@melvin-bot melvin-bot bot added the Overdue label Jul 13, 2023
@johncschuster
Copy link
Contributor

Got it. Thanks for spelling that out!

@melvin-bot melvin-bot bot removed the Overdue label Jul 14, 2023
@johncschuster
Copy link
Contributor

So in that case, it sounds like we can close this issue out. Does that sound right to you, @jeet-dhandha?

@jeet-dhandha
Copy link
Contributor

Aye aye, sir 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants