Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - More than 4 Avatars are displayed on the A group chat #22469

Closed
1 of 6 tasks
kbecciv opened this issue Jul 8, 2023 · 5 comments
Closed
1 of 6 tasks

Web - More than 4 Avatars are displayed on the A group chat #22469

kbecciv opened this issue Jul 8, 2023 · 5 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on FAB
  2. Create a group chat with more than 4 users.
    notice that all the avatars are displayed on the created group chat page.

Expected Result:

4th avatar overlaid with the number when there are more than 4 users.

Actual Result:

all the avatars are displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test66_Avaterlist-1.mp4
Recording.3504.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688796213466909

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 8, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@allroundexperts
Copy link
Contributor

I think is expected as per #21402

@cristipaval
Copy link
Contributor

yes, Thank you @allroundexperts! It looks like this is expected.

@cristipaval
Copy link
Contributor

@kbecciv could you please update your test cases accordingly?

@cristipaval cristipaval removed the DeployBlockerCash This issue or pull request should block deployment label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants