HOLD for #21977 [$1000] When an anonymous user copies a message, the app says "Copied", but it DOES NOT actually copy the message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Logout current user or open web app in private mode
2. Open any room as an anonymous user. SNH room for example: https://staging.new.expensify.com/r/5303403427249671
3. HOVER on any message and select “Copy to clipboard” option. Observer that:

• The app shows “Copied” - but it DOES NOT actually copy the message
• User is re-directed to login page

Expected Result:

The message should be actually copied (not just shown “Copied” label)

Actual Result:

The app says "Copied", but it DOES NOT actually copy the message and then redirects the user to the login page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.7-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Copy-message.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688384968610059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011eb534d2568f9e9b
• Upwork Job ID: 1676700818736766976
• Last Price Increase: 2023-08-02

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011eb534d2568f9e9b

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Copy to clipboard option does not actually copy in the case of an anonymous user.

What is the root cause of that problem?

The onPress event is handled by interceptAnonymousUser, which ignores the callback if the user is anonymous. Furthermore, it leads to the user being redirected to the sign in page.

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Line 121 in cb7988c

onPress={() => interceptAnonymousUser(() => contextAction.onPress(closePopup, payload))}

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Lines 74 to 84 in cb7988c

	const interceptAnonymousUser = (callback) => {
	if (Session.isAnonymousUser()) {
	hideContextMenu(false);
	InteractionManager.runAfterInteractions(() => {
	Session.signOutAndRedirectToSignIn();
	});
	} else {
	callback();
	}
	};

What changes do you think we should make in order to solve the problem?

In order to achieve the expected result, which is to copy the message and not redirect to the signin page, we can modify the contextAction and add an extra value called shouldInterceptAnonymousUser.

We can then conditionally ignore the callback if this value is true.

const interceptAnonymousUser = (callback, shouldInterceptAnonymousUser) => {
    if (Session.isAnonymousUser() && shouldInterceptAnonymousUser) {

What alternative solutions did you explore? (Optional)

Option 1: We can expand Session.checkIfActionIsAllowed and add 3 arguments to make it compatible with the user case here:

• shouldRunAfterInteractions
• hideContextMenu
• isAnonymousAllowed

This gives a general solution that can also be applied elsewhere, such as:

App/src/pages/home/report/ReportActionItem.js

Lines 351 to 361 in f08ab19

	toggleReaction={(emoji) => {
	if (Session.isAnonymousUser()) {
	hideContextMenu(false);
	InteractionManager.runAfterInteractions(() => {
	Session.signOutAndRedirectToSignIn();
	});
	} else {
	toggleReaction(emoji);
	}
	}}

Option 2: we can incorporate the condition in the onPress event, however this is slightly less readable code.

[AdekolaThanni]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The copy to clipboard does not copy text for anonymous user although it sends a copied signal before logging client out.

What is the root cause of that problem?

The onPressAction triggers the interceptAnonymousUser which blocks the anonymous user from copying text to clipboard and then leading to a sign out.

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Line 121 in cb7988c

onPress={() => interceptAnonymousUser(() => contextAction.onPress(closePopup, payload))}

What changes do you think we should make in order to solve the problem?

The change we can make in order to allow a user to copy text to the clipboard directly since we have no aim of signing them out if they are an anonymous user is to remove the actionless code of passing interceptAnonymousUser to the onPress function, instead, we pass the callback directly. Such as this

onPress={() => contextAction.onPress(closePopup, payload)}

What alternative solutions did you explore? (Optional)

None

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app says "Copied", but it DOES NOT actually copy the message and then redirects the user to the login page.

What is the root cause of that problem?

We need to allow only "Copy" for AnonymousUser. not allow others like "Reply" and "Reaction"
The root cause of this problem is that "AnonymousUser" is redirected to "Signin Page" when click copy.

What changes do you think we should make in order to solve the problem?

We need to add a flag to "Copy" of ContextMenuActions to allow for "AnonymousUser" to copy text.
So we can make if user allow "copy" without "signin" and not allow "reply" without "signin".

Screen.Recording.2023-07-06.at.11.28.59.PM.mov

What alternative solutions did you explore? (Optional)

[Santhosh-Sellavel]

@adelekennedy Please add a HOLD label here to the issue, we are working on fixing this holistically on #21977.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

still holding on this

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

hold

[PauloGasparSv]

Hey @adelekennedy @Santhosh-Sellavel sorry for the delay, I was OOO and got back this week : )

The fix from #21977 worked and now the copy button is working fine for anonymous users!

Screen.Recording.2023-08-01.at.18.48.52.mov

I'm not sure if we need to compensate who reported this first but please feel free to close this!

[adelekennedy]

Thank you!

Payment Summary

@tranvantoan-qn - $250 for reporting bonus (paid via Upwork)

In this case I think only the reporting bonus is due because we put this on hold so quickly.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

reporting paid out. closing this!