[HOLD for payment 2023-09-04] [$1000] Not allowed sign does not show when an attachment is drag and dropped

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat and upload a picture
2. Open the picture uploaded
3. Open a file > drag and drop any picture without closing the picture shown.
4. Notice that not allowed sign is not shown

Expected Result:

Not allowed to drag and drop when an attachment is open.

Actual Result:

allowed to drag and drop when an attachment is open.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test56_Dragdrop-1.mp4

Recording.1162.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688500850249469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010870acccad3ed186
• Upwork Job ID: 1676676820896407552
2023-07-26
• Automatic offers:
• daveSeife | Reporter | 25785739

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flaviadefaria]

Just coming online, but @deetergp seems to be on it!

[Julesssss]

This one is problematic. It looks like @deetergp located the original PR, but as we've already followed up with additional changes for other blockers I don't think we can simply revert it...

Best course of action might be to unblock the release and resolve this without classing it as a blocker. I think this is fine as it's not blocking the user.

We're already one day behind the release schedule and the alternative of reverting multiple PRs in a certain order is too time-consuming/complex and will prevent me from releasing.

[Julesssss]

@kidroca it would be great if you could confirm/deny our suspicion about this. We'll need to fix but I'm moving forward with the app release.

[deetergp]

I'd love @kidroca's thoughts on it, but I'm going to go ahead and apply the External label and open it up to proposals.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010870acccad3ed186

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[rain2o]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Drag and drop is not prevented in the attachment preview modal.

What is the root cause of that problem?

As suspected in previous comments, this is a result of the restructuring in #20167. Previously, AttachmentModal was a child of ReportScreen, and it benefited from the logic in DragAndDrop, which prevents drag & drop outside of the specified area. Now that AttachmentModal is in its own RootStack.Screen, it no longer benefits from that logic.

What changes do you think we should make in order to solve the problem?

We need to add these event handlers to ReportAttachments, as this is the top-level component for the new stack dedicated to showing attachment modals.

We can use the same logic as is in DragAndDrop, but much more simplified.

const preventDropEvent = useCallback((event) => {
    event.preventDefault();
    // eslint-disable-next-line no-param-reassign
    event.dataTransfer.dropEffect = 'none';
}, []);

useEffect(() => {
    document.addEventListener('dragenter', preventDropEvent);
    document.addEventListener('drop', preventDropEvent);

    return () => {
        document.removeEventListener('dragenter', preventDropEvent);
        document.removeEventListener('drop', preventDropEvent);
    }
}, [preventDropEvent])

What alternative solutions did you explore? (Optional)

We could wrap ReportAttachments in the DragAndDrop component and set shouldAcceptDrop to always return false. But I think this would add unnecessary bloat to this stack, as there's a bit going on under the hood in that component.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable Drag & Drop by default #24536

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ginsuma requires payment
• @allroundexperts does not require payment (Eligible for Manual Requests)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

Payment summary:

For reference, here are some details about the assignees on this issue:
@ginsuma requires payment
@allroundexperts does not require payment (Eligible for Manual Requests)
@daveSeife requires payment offer (Reporter)

@ginsuma = $1000 (no bonus)
@allroundexperts = $1000 (no bonus)
@daveSeife = $250

[melvin-bot]

@deetergp, @ginsuma, @allroundexperts, @flaviadefaria Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@deetergp, @ginsuma, @allroundexperts, @flaviadefaria Huh... This is 4 days overdue. Who can take care of this?

[flaviadefaria]

@ginsuma can you please share your UW profile here, I'm not sure that I have found the right person- thanks!
@daveSeife - Contract sent.

[flaviadefaria]

Thanks, @ginsuma - contract sent.

[ginsuma]

@flaviadefaria I'm the contributor who fixed the issue. Your offer is $250.

[flaviadefaria]

Oops, sorry about that, sent a new offer with the correct amount.

[flaviadefaria]

@ginsuma - paid
@daveSeife - waiting to accept offer

[daveSeife]

@flaviadefaria accepted offer, thank you!

[flaviadefaria]

@daveSeife you have been paid.

@allroundexperts does not require payment (Eligible for Manual Requests)

@allroundexperts please request payment I'll switch this to weekly for now.

[deetergp]

Still holding for payment?

[allroundexperts]

Requested payment.

[flaviadefaria]

Cool seems like all payments have been requested or made so closing this for now.

[JmillsExpensify]

$1,000 payment approved for @allroundexperts based on BZ summary.