Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Email Test - The username on the left hand navigation isn't displayed bold when a new message arrives #2177

Closed
isagoico opened this issue Mar 31, 2021 · 7 comments
Labels
DeployBlockerCash This issue or pull request should block deployment

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

The username on the left hand navigation is displayed bold when the email message arrives

Actual Result:

The username on the left hand navigation isn't displayed bold

Action Performed:

  1. Go to https://staging.expensify.cash/ and login
  2. As account A send some messages to an account that must be a main email address without the +. Wait 10 minutes. This will trigger an email notification to this account.
  3. Log out of Account A
  4. After 10 min has passed, check the main account email inbox and open the mail with this name "Chat between and ".
  5. Answer to the email with any message.
  6. Wait a minute or 2 and log into both accounts (A and main account).
  7. Verify the message you sent via email is displayed for both accounts and The username on the left hand navigation is displayed bold (unread message)

Workaround:

Unknown

Platform:

Where is this issue confirmed?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.10-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
Issue is not reproducible in production.

image

image

Expensify/Expensify Issue URL:

@isagoico isagoico added AutoAssignerTriage Auto assign issues for triage to an available triage team member DeployBlockerCash This issue or pull request should block deployment labels Mar 31, 2021
@MelvinBot
Copy link

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 31, 2021
@marcaaron
Copy link
Contributor

Probably we should not add AutoAssignerTriage label to issues that are deploy blockers.

@marcaaron
Copy link
Contributor

Verify the message you sent via email is displayed for both accounts and The username on the left hand navigation is displayed bold (unread message)

Just wanted to clarify this expectation. Since you have sent a message and responded via email this should not appear to be bold on both accounts. Only bold on the account that did not respond via email.

Asking because I think anytime we add a new message we will assume you've seen all messages before this one.

cc @chiragsalian to double check this. Here's where it happens in the code

As for why a different result can be seen on production. I'm not sure, but maybe we can retest to see if the result is the same.

@chiragsalian
Copy link
Contributor

chiragsalian commented Apr 2, 2021

Yeah what marc says sounds correct. So if account B sends a message to account A via email, then the message will show up as bold just for account A in ecash and not for B.

Also I'm not sure why the result was different on production. Thats odd. Anyway I'm going to test your staging steps now in a bit.

@chiragsalian
Copy link
Contributor

I just tested on staging and the message showed up as bold for me,
image

Account A i used was chirag@expensify.com
Account B i used was chirag.exp.test2@gmail.com

I sent a message from Account A to Account B. Waited 10minutes for the email to show up for Account B. Had Account B reply to the email while making sure Account A didn't already highlight the chat with Account B (because if that chat was in focus it would have been bolded and considered read immediately). One B sent the email it shows up as bolded for Account A as shown in the screenshot above.

Let us know if you meant to test this differently

@isagoico
Copy link
Author

isagoico commented Apr 2, 2021

Yep you tested it correctly. This is weird, me and the tester were able to reproduce this consistently on the day it was reported. Now I'm not able to reproduce this anymore in staging. Maybe we could close it and reopen if we experience this again.
image

@chiragsalian
Copy link
Contributor

Maybe we could close it and reopen if we experience this again.

Yup, that sounds great 👍 Thank you for retesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

No branches or pull requests

5 participants