Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - On Confirm task page, a long description takes the page height, and Confirm task button is not visible, and the page is not scrollable. #21588

Closed
1 of 6 tasks
kbecciv opened this issue Jun 26, 2023 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open App & Press FAB > Assign task
  2. Enter the Title and Enter a multiline description(with around 20 line breaks)
  3. Press Next
  4. Observe the description text & Confirm task button position and Try to scroll the page.

Expected Result:

Either description should be limited to some maximum height, or the page should be scrollable

Actual Result:

The description took the height of the page, and the page is not scrollable.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug-assign-task-multiline-description.1.mov
Desktop.2023.06.25.-.21.50.21.17.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687439102604279

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 26, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Confirm task page, a long description takes the page height, and Confirm task button is not visible, and the page is not scrollable

What is the root cause of that problem?

We haven't used ScrollView for the confirm task page.

<View style={[styles.mt5, styles.containerWithSpaceBetween]}>

What changes do you think we should make in order to solve the problem?

Replace View with the ScrollView here and use contentContainerStyle prop with it.

<View style={[styles.mt5, styles.containerWithSpaceBetween]}>

@dhairyasenjaliya
Copy link
Contributor

@greg-schroeder this is dupe issue and can be closed in favor of #21347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants