[HOLD for payment 2023-07-20] Standardize on the iOS pod version to prevent the useless diff

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

cc @Expensify/mobile-deployers for your thoughts. Any concerns? Or suggestions for the version we align on?

Problem

We don't have a standard cocoapods version, so as developers we often see a useless diff that changes the version to match our local version. This is mildly annoying and a bit confusing.

Solution

Align on a version, preventing this diff from being generated locally.

---

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1687224504406749

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

Aligning on a version sounds good to me. How are we thinking of enforcing it?

[lindboe]

A typical project would align on whatever's in the Gemfile (as this will also be updated in future React Native releases if an upgrade is needed).

To enforce that, some ideas, ranked by cost:

1. Using bundle install and bundle exec pod install should be documented in the project setup steps
2. We could add an alias of npm run pod install that uses bundle exec pod install
3. We could create a Makefile system that runs all dev environment setup steps (or permutations of it). This might have other benefits for the dev build experience, like ensuring that patch-package is run. (I think the post-install command might be easy to miss)
4. Could add a lint step to PRs that ensures either:
   a. re-running bundle exec pod install does not generate Podfile.lock changes (I'm a little worried this may have some edge cases where the change generated isn't meaningful, due to slight differences in CI environment from a typical dev environment, which would increase maintenance costs)
   b. that the Podfile.lock pod version matches the version in the Gemfile (requires parsing it)

[roryabraham]

Nice! I happened to suggest this same thing in a different context just this morning: #18507 (comment)

I think this may have been a cause of problems w/ pod caching in our CI/CD, which we had to remove because it was unreliable

[lindboe]

@Julesssss we haven't worked on issues like this before, is the expectation that we make a proposal/get feedback or just make a PR and get feedback that way?

[roryabraham]

I think in this case this change is minor enough that you can just open a PR and get feedback that way 🙂

[Julesssss]

Yeah, no need in this case. Also I tagged everyone on the mobile deploy team, so silence on this issue is similar to approval 🙂

[luacmartins]

Agreed, just go for a PR here.

[lindboe]

Since this was merged to main, should we announce in the open-source channel that it should be used going forward?

[roryabraham]

Yep, let's do it 👍🏼

[lindboe]

Done: https://expensify.slack.com/archives/C01GTK53T8Q/p1689101140745419

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[anmurali]

@Julesssss can you confirm?

[Julesssss]

Hey @anmurali, yep the default $1k is correct 👍

[Julesssss]

This isn't a regression, so I hid the regression checklist comment.

[JmillsExpensify]

Reviewed details for @rushatgabhane. This is accurate and approved for payment in NewDot.

[melvin-bot]

@lindboe, @Julesssss, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

Ready for payment

[melvin-bot]

@lindboe, @Julesssss, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

Not overdue, just awaiting payment

[melvin-bot]

@lindboe, @Julesssss, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

Hey @anmurali, I forgot to reassign while you were OOO, my bad. Please make the payment when you have a moment 👍

[melvin-bot]

@lindboe, @Julesssss, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

Payments:

• External issue reporter N/A
• Contributor that fixed the issue @lindboe $1k - Paid via invoice to Infinite Red
• Contributor+ that helped on the issue and/or PR - @rushatgabhane has been paid on new Dot

[lindboe]

@anmurali I do not get paid through Upwork, I work for Infinite Red

[melvin-bot]

@lindboe, @Julesssss, @anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@lindboe, @Julesssss, @anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@lindboe, @Julesssss, @anmurali Still overdue 6 days?! Let's take care of this!