Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Conversation without messages is still displayed after navigating away #2121

Closed
isagoico opened this issue Mar 27, 2021 · 20 comments
Closed
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

When navigating away, the conversation should not be displayed in the LHN if it doesn't have any messages.

Actual Result:

When navigating away from the conversation it is still displayed in the chat list

Action Performed:

  1. Download the latest Android build open it and login
  2. Tap on the + and select the new chat option
  3. Search for a user that you don't have messages with
  4. Open the chat
  5. Without sending any message, navigate away from chat.

Workaround:

Unknown

Platform:

Where is this issue confirmed?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.7-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Unable to check if the issue is reproducible in the production app.
I Checked the behaviour in Web and the conversation does disappear when navigating away

Whatsapp.Video.2021-03-26.At.8.36.53.Pm-1.mp4

Expensify/Expensify Issue URL:

@marcaaron marcaaron added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 31, 2021
@MelvinBot
Copy link

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 31, 2021
@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johncschuster johncschuster removed their assignment Mar 31, 2021
@joelbettner
Copy link
Contributor

I think this has what it needs to be worked on by an engineer. Un-assigning myself for triage.

@joelbettner joelbettner removed their assignment Apr 16, 2021
@mallenexpensify
Copy link
Contributor

@joelbettner "I think this has what it needs to be worked on by an engineer. Un-assigning myself for triage."
When you say engineer do you mean an external contributor? I'm guessing yes but want to be sure

@mallenexpensify mallenexpensify self-assigned this May 2, 2021
@mallenexpensify mallenexpensify added Daily KSv2 and removed Daily KSv2 labels May 2, 2021
@mallenexpensify
Copy link
Contributor

Double checking with Joel before posting

@joelbettner
Copy link
Contributor

@mallenexpensify yes, external contributor or Expensify engineer. Either should be fine.

@mallenexpensify
Copy link
Contributor

@johncschuster tossing back to you since you were the original auto-assigned triager, can you post to Upwork plz.

@mallenexpensify
Copy link
Contributor

Strike that, I should add the External label to get someone from the CM team assigned, NOT a triager. Sorry @johncschuster

@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label May 5, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@parasharrajat
Copy link
Member

parasharrajat commented May 5, 2021

It seems like correct behavior. Actually, that chat is currently active(which means if you slide right you would see that report)so it is visible in LHN. if you switch to another chat then it would be removed from LHN.

@shawnborton But it does trigger one question, Do we need to highlight the active chat in some way on LHN in mobile devices?

@isagoico
Copy link
Author

isagoico commented May 9, 2021

Issue reproducible during today's KI retests

1 similar comment
@isagoico
Copy link
Author

isagoico commented May 17, 2021

Issue reproducible during today's KI retests

@isagoico
Copy link
Author

Issue reproducible during today's KI retests

@isagoico
Copy link
Author

Issue reproducible today during KI retests

2 similar comments
@isagoico
Copy link
Author

isagoico commented Jun 7, 2021

Issue reproducible today during KI retests

@isagoico
Copy link
Author

Issue reproducible today during KI retests

@kevinksullivan
Copy link
Contributor

Sorry I missed this one. I also think it is ok for the conversation to remain if it disappears once no longer "active". That said I think consistency across platforms is important here. @isagoico does iOS immediately disappear?

@isagoico
Copy link
Author

Issue reproducible today during KI retests.

@isagoico
Copy link
Author

Yes, iOS has the same behaviour. So when I reproduced the issue I think this may be the expected behaviour. The conversation does disappear when you navigate to another conversation. On mobile it looks like you're navigating away but you need to navigate to another conversation to "close" the other one.

@kevinksullivan
Copy link
Contributor

Got it. I think we'll close this one out for now then. Feel free to reopen if I am missing anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants