[HOLD for payment 2023-07-17] [$1000] Fix design for anonymous report footer

[marcochavezf]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from this comment, we want to fix the design and breakpoints for the report footer, which is displayed when an unauthenticated user opens a public room. Additionally, the report footer disappears in a room with several comments:

Action Performed:

Open a public room (like ECX announce) as unauthenticated user

Expected Result:

The report footer should look like this:

Actual Result:

The breakpoints for mobile view are not displaying the elements as expected

And the footer should be fixed:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a1ba14253aff0dd0
• Upwork Job ID: 1668673550838931456
• Last Price Increase: 2023-06-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a1ba14253aff0dd0

[melvin-bot]

Triggered auto assignment to @muttmuure (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Current assignee @marcochavezf is eligible for the External assigner, not assigning anyone new.

[Vishrut19]

Can I submit a proposal and work on this issue ? Or this issue will also won't be assigned to me ?

[aimane-chnaif]

Can I submit a proposal and work on this issue ? Or this issue will also won't be assigned to me ?

I think @allroundexperts will most likely work on fixing this - #20494 (comment)

[aimane-chnaif]

@marcochavezf can you please confirm if this is open for proposals or just assign @allroundexperts?

[marcochavezf]

Since @allroundexperts asked to take this one on the other issue and implemented the report footer for anonymous users I think makes sense to assign him here

[melvin-bot]

📣 @allroundexperts You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Vishrut19]

I don't know what kind off system this open source project has because you don't give chance to new folks to come and contribute to this project. There are set number of folks who just get all the issue, one after the other after the other.I think open source is a place where anyone can try to contribute and i always had the notion that it's all about collaboration, but now I got to know that it's all about some group of people only here in Expensify

[Vishrut19]

I don't know what kind off system this open source project has because you don't give chance to new folks to come and contribute to this project. There are set number of folks who just get all the issue, one after the other after the other.I think open source is a place where anyone can try to contribute and i always had the notion that it's all about collaboration, but now I got to know that it's all about some group of people only here in Expensify

That's really awful from Expensify Team. Really Really Awful 👎👎

[mountiny]

@Vishrut19 sorry you having this experience. There are certain issues we prefer to offload to expert agencies we contract with in which case we assign those to their engineers but we try to make sure that in such case the issues dont have Help Wanted label to not waste contributors time.

There is plenty first time contributors you can see in the PR section, so I would definitely not say issues are assigned to only existing contributors, however, I appreciate its a steep learning curve to land your first PR. It is easier later on as you are more familiar with the codebase.

I hope you can still land your first and many PRs to come in future

[Vishrut19]

Also, I am unable get my hands on to the codebase and no one is ready to help. Is there any way I can get my hands on to the codebase ?

[mountiny]

You can see all the code here https://github.com/Expensify/App

[marcochavezf]

Hi @Vishrut19, my apologies. This is a follow-up of a previously implemented issue, and I decided to move with @allroundexperts since we want to fix it on production this week if possible, he implemented the component that we want to modify and offered to take this one first here. Also, you can find here some of our guidelines to contribute to the codebase.

[shawnborton]

Not overdue

[muttmuure]

Clarifying something here

[melvin-bot]

@shawnborton, @marcochavezf, @allroundexperts, @muttmuure, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Catching up from ooo

[muttmuure]

This was assigned on Jun 13th, and approved on June 25th, so I need to apply the 50% penalty in this case.

I've invited @allroundexperts and @aimane-chnaif to apply.

Let me know if you have any questions. Thanks!

[aimane-chnaif]

There was waiting period from @marcochavezf (Jun 17 - June 23)

[aimane-chnaif]

Jun 13th, and approved on June 25th,

Even though we don't consider waiting period, 8 business days total between 13th - 25th which isn't eligible for penalty

[allroundexperts]

@muttmuure I'll be paid through the app.

[shawnborton]

Not overdue, just closing out payments here.

[marcochavezf]

Not overdue, just closing out payments here.

[JmillsExpensify]

@muttmuure Can you summarize all payments on this issue before I approve in NewDot. More context in Slack.

[muttmuure]

@aimane-chnaif is right there is no penalty because it's 8 business days. Thanks for clarifying!

[muttmuure]

@aimane-chnaif - $1000 for C+
@allroundexperts - $1000 for C

[JmillsExpensify]

Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

[melvin-bot]

@shawnborton, @marcochavezf, @allroundexperts, @muttmuure, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[muttmuure]

Catching up from OOO

Offer sent to @aimane-chnaif

[muttmuure]

@aimane-chnaif paid, closing out