[$1000] Share code - Light background does not appear below the avatar image (reported by @alitoshmatov)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19883

Action Performed:

1. Open the App and upload a profile picture that has a transparent background.
2. Go to Settings -> Share code

Expected Result:

Verify that a light green background appears below the avatar image.

Actual Result:

A light green background does not appear below the avatar image.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6085932_Recording__267.mp4

Expensify/Expensify Issue URL:

Issue reported by: @alitoshmatov / Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686247175943009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a3d4105d7772fca
• Upwork Job ID: 1668408135973871616
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Light background doesn't appear below the avatar image

What is the root cause of that problem?

We don't pass logoBackgroundColor props here so the default value(defaultTheme.icon) is used.

App/src/components/QRCode/index.js

Lines 62 to 73 in 4dc58e7

	<QRCodeLibrary
	getRef={props.getRef}
	value={props.url}
	size={props.size}
	logo={props.logo}
	logoBackgroundColor={props.logoBackgroundColor}
	logoSize={props.size * props.logoRatio}
	logoMargin={props.size * props.logoMarginRatio}
	logoBorderRadius={props.size}
	backgroundColor={props.backgroundColor}
	color={props.color}
	/>

App/src/components/QRCode/index.js

Line 53 in 4dc58e7

logoBackgroundColor: defaultTheme.icon,

What changes do you think we should make in order to solve the problem?

Set the default logoBackgroundColor to defaultTheme.highlightBG

    logoBackgroundColor: defaultTheme.highlightBG

Result

What alternative solutions did you explore? (Optional)

[alitoshmatov]

I have reported this here - https://expensify.slack.com/archives/C049HHMV9SM/p1686247175943009

There are two problems

1. When png uploaded, backend is converting it to jpeg and it is getting default dark background
2. fix: add background to share code avatar #19883 produced the regression where every logo in qr code have grey background

[strepanier03]

@alitoshmatov - Is this being fixed with the PR you mentioned? Do you recommend we put this GH on hold for now?

[alitoshmatov]

@strepanier03 No this PR is the one causing the regression, right now there is no PR to fix this yet. I think someone should confirm that this is indeed regression of #19883 and state next steps.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a3d4105d7772fca

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[strepanier03]

Got it, thanks @alitoshmatov!

[mollfpr]

@strepanier03 @aldo-expensify I'm unsure if this a regression from #19883 as it is expected before @allroundexperts put up the PR.

Although, the result is not correct as expected in other PR that hit the production first #19984 (comment)

[strepanier03]

@aldo-expensify - Can you please help up determine the regression here and next steps? I am heading out for sabbatical this evening so I will be reassigning this to another BZ momentarily.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[strepanier03]

@trjExpensify - Sorry to give you another but I've got a lot of BZ issues to hand off 😬.

I bumped the eng here to help figure out the regression and then this will need some pressure to keep moving forward. For today there is no immediate action required from you.

Thank you for wrapping this up 🙌

[aldo-expensify]

@shawnborton to confirm what is the expected look of this:

Current:

This following is the expected background for the Share QR, right?

[shawnborton]

@alitoshmatov where did we end up with this? I think we originally decided that we should use the icon color as the BG color behind all transparent avatars everywhere in the app. However, I can see an argument to do something like the second screenshot above just for this particular QR code screen.

[aldo-expensify]

If we agree with going with the second option above, we just have to revert #19883

[allroundexperts]

@aldo-expensify correctly pointed this out. I think this ticket is not needed since we just have to revert #19883. However, I don't think that the revert should be treated as a regression because as seen clearly in the conversation here, the expectation was to set the same background colour as we're setting elsewhere.

[aldo-expensify]

I think this ticket is not needed since we just have to revert #19883.

Agreed, unless there is a payment for reporting for @alitoshmatov . @trjExpensify do you think reporting reward applies here?

However, I don't think that the revert should be treated as a regression because as seen clearly in the conversation #19569, the expectation was to set the same background colour as we're setting elsewhere.

I'm fine with not considering it a regression, I understand that there was work in parallel addressing similar things in separate issues/PRs made it pretty hard to see that this was going to happen. I'm not sure what it means for your compensation on #19883 if we just revert it.

@allroundexperts can you put up a revert PR? 🙏

[allroundexperts]

@allroundexperts can you put up a revert PR? 🙏

Sure thing!

[allroundexperts]

#20938

Do I need a checklist for the revert as well @aldo-expensify?

[aldo-expensify]

#20938

Do I need a checklist for the revert as well @aldo-expensify?

Thanks, I added the checklist to the body.

[alitoshmatov]

The issue was that QR codes with expensify logo and non-transparent avatars were not checked after the changes. These changes were only aimed at fixing transparent avatars.

[trjExpensify]

Agreed, unless there is a payment for reporting for @alitoshmatov . @trjExpensify do you think reporting reward applies here?

Was this the first time the bug was surfaced? If so, then I think payment for the bug report would be due.

[melvin-bot]

@trjExpensify @mollfpr @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@trjExpensify, @mollfpr, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

Was this the first time the bug was surfaced? If so, then I think payment for the bug report would be due.

I think it is the first time, I couldn't find other mentions.

[trjExpensify]

Offer sent for the bug report @alitoshmatov here.

[alitoshmatov]

Accepted offer

[trjExpensify]

Cool, I've paid that out so going to close this issue now. Thanks!