-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-19] [$1000] Web - Login - "Incorrect magic code" error if click "Go back" in 2FA input page #19712
Comments
Triggered auto assignment to @bfitzexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Redirects to authenticator code screen again when user clicks go back to change email when 2FA enabled What is the root cause of that problem?Because when we click on text link "Go back". It will clear all the sign in data If we are on 2FA screen, it will unmount and mount again What changes do you think we should make in order to solve the problem?We need to clear this.setState({twoFactorAuthCode: '', formError: {}, validateCode: ''}); So it will prevent to submit magic codes when we go back to input email screen. |
Hello team I just wanted to let you know I originally reported this issue here on slack. |
Reproduced. |
Job added to Upwork: https://www.upwork.com/jobs/~0117c06543ed99c789 |
Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Triggered auto assignment to @tgolen ( |
I can fix this bug. Let's discuss more detail. |
📣 @JavSFDev! 📣
|
Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new. |
Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to @luacmartins ( |
@rushatgabhane @luacmartins PR is ready #19944. Please help me review it. Thanks |
@luacmartins @rushatgabhane Seems this issue is similar. |
@hoangzinh, @luacmartins, @rushatgabhane, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Melvin, PR is merged. Waiting for QA testing & deploy to production. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-19. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Won't be able to complete the checklist this week. (We can make this a weekly if that's okay) |
No problem @rushatgabhane - let's leave it a daily for the moment just so the priority is still correct, but noted that it won't be completed until next week |
@rushatgabhane just a reminder to complete the checklist this week when you get a chance - thanks! |
|
Hey @bfitzexpensify, Anu is setting up global payments through new expensify for us. It might take another week or two, and we'll have the clarity of next steps for payment. Until then, we could make this a weekly issue? I hope this is okay :) |
@rushatgabhane thanks for completing the checklist! Happy to switch this to a weekly. Just a note on that — that means I won't be checking this issue every day, so if you can ping here once the new payment method is ready to go, I'll get that payment processed ASAP. |
Hi @bfitzexpensify, I made a manual request on new dot https://staging.new.expensify.com/r/7305054148899705 |
This is paid on new dot! |
Awesome — OK, we can close this out, thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Precondition - User has setup a 2FA to log into account
Open https://staging.new.expensify.com/
Input email for account from the precondition
Click "Continue"
4.Input magic code
Click "Continue
Click "Go back"
Expected Result:
User lands in login page with no errors
Actual Result:
User lands in login page with an error about incorrect magic code displayed - "Incorrect magic code. Please try again or request a new code".
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6069882_Recording__607.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: