[$1000] Share code - Unable to go to the chat with a user whose email address has "+"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #18636

Action Performed:

1. Log into an account that has a + in the email, ex: example.user+test@applause.expensifail.com
2. Go to URL https://staging.new.expensify.com/
3. Go to Settings > Share code
4. Using another phone, scan the QR code on the page and verify that it takes you to New Dot to view the profile page of the user
5. Tap Massage example.user+test@applause.expensifail.com

Expected Result:

User can jump to a conversation with another user using a QR code.

Actual Result:

The user sees an error in the chat and is not able to send messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.9

Reproducible in staging?: Yes

Reproducible in production?: new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230516_112421_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684165146584739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01efcc2d2440f70193
• Upwork Job ID: 1660658319748927488
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The + sign in the email address disappears when opening from a deep link provided by the QR code.

Note: This issue also exists for the Copy to clipboard button.

What is the root cause of that problem?

The reason for this is because the string is not URI encoded before converting it into a QR code.

What changes do you think we should make in order to solve the problem?

To solve this, we first encode the string and then convert it into a QR code. In the line below,

App/src/pages/ShareCodePage.js

Line 41 in fa0ec1b

const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${this.props.session.email}`;

The email part of it the url has to be URI encoded using the encodeURIComponent() function,

const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${encodeURIComponent(this.props.session.email)}`;

What alternative solutions did you explore? (Optional)

None.

[therealsujitk]

@sonialiap the email address of the QR you're scanning should contain a + in it (ex: mail+test@example.com). Also the same issue should happen for the copy to clipboard button (You can test with that too).

[sonialiap]

Whops, I didn't notice the + requirement, thanks for the correction, trying it now with an email address that has a +

[sonialiap]

Oh yeah, when testing with an email address that has a +, I can reproduce the error. I will update the steps to specify this

screen-20230522-163822.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01efcc2d2440f70193

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[francoisl]

This was already fixed in #19249, this was a duplicate issue we didn't realize.

[francoisl]

Reopening this so we can pay @Nathan-Mulugeta for reporting the issue once #19249 is deployed (as discussed starting here).
(cc @michaelhaxhiu)

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@francoisl, @sonialiap, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@francoisl, @sonialiap, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

[francoisl]

Looks like payment for reporting the issue is complete (#19076 (comment)), closing.