Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-27] LHN edited message UI shows the whole multiline message for a few seconds #17574

Closed
6 tasks
kavimuru opened this issue Apr 18, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Apr 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Send Any multiline code block message to chat
  2. Observe the LHN list of the chat
  3. Now edit the same multiline code block message
  4. Observe the LHN

Expected Result:

LHN should show only the first line of the message

Actual Result:

It shows the whole message for a few seconds in LH

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.263.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681820355045809

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b50c1ba8e6e2cc4f
  • Upwork Job ID: 1651464466008215552
  • Last Price Increase: 2023-04-27
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2023
@MelvinBot
Copy link

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 18, 2023

Seems a regression from this PR

@francoisl
Copy link
Contributor

Fix is being CPed to staging now.

@kerupuksambel
Copy link

Hi, sorry but it seems that this issue is pretty similar with what found here, that was reported first in the Slack conversation. https://expensify.slack.com/archives/C049HHMV9SM/p1681809609978589

@iwiznia
Copy link
Contributor

iwiznia commented Apr 18, 2023

Should I close this then? It is already being handled in #17212

@francoisl
Copy link
Contributor

Hi, sorry but it seems that this issue is pretty similar with what found here, that was reported first in the Slack conversation. expensify.slack.com/archives/C049HHMV9SM/p1681809609978589

Yes it seems we need to change the "Issue reported by" for this issue @kavimuru, though I'm not sure about the exact procedure and if there's something else to to change too.

@iwiznia I'd say let's wait until the original issue and the fix are QA'ed on staging and then we can close.

@mountiny
Copy link
Contributor

Thanks for handling this, I have update the issue body to mention @kerupuksambel as reported as they reported it first.

Confirmed that this is fixed in staging @sakluger could you please handle the $250 report bonus to @kerupuksambel for this and then we can close this

@mountiny mountiny added Daily KSv2 and removed Hourly KSv2 labels Apr 18, 2023
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 19, 2023
@MelvinBot
Copy link

@iwiznia, @sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2023
@mountiny mountiny changed the title LHN edited message UI shows the whole multiline message for a few seconds [HOLD for payment 2023-04-27] LHN edited message UI shows the whole multiline message for a few seconds Apr 26, 2023
@mountiny
Copy link
Contributor

This is ready to pay the reporting bonus of $250

@sakluger
Copy link
Contributor

I'm having a hell of a time creating a job manually in Upwork, it keeps returning errors. I'm going to apply the internal label to get the job created, then I'll fix everything from there.

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2023
@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Apr 27, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01b50c1ba8e6e2cc4f

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@sakluger sakluger removed the Internal Requires API changes or must be handled by Expensify staff label Apr 27, 2023
@sakluger
Copy link
Contributor

@mollfpr, you can disregard, this issue is just for paying a reporting bonus and so I've unassigned you.

@sakluger
Copy link
Contributor

@kerupuksambel I've sent you an offer through upwork.

@sakluger
Copy link
Contributor

All paid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

10 participants