Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pay on 26-4][$1000] Native platforms crashing due to nbsp outside Text component #17414

Closed
2 of 6 tasks
chiragsalian opened this issue Apr 13, 2023 · 16 comments
Closed
2 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@chiragsalian
Copy link
Contributor

chiragsalian commented Apr 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

https://expensify.slack.com/archives/C049HHMV9SM/p1681412584546029

Expected Result:

https://expensify.slack.com/archives/C049HHMV9SM/p1681412584546029

Actual Result:

https://expensify.slack.com/archives/C049HHMV9SM/p1681412584546029

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011dca5d263f2f7434
  • Upwork Job ID: 1648042928460636160
  • Last Price Increase: 2023-04-17
@chiragsalian chiragsalian added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 13, 2023
@MelvinBot
Copy link

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@chiragsalian
Copy link
Contributor Author

@parasharrajat whipped up a PR soon and we merged it so that the app continues to work properly for our contributors.

@bfitzexpensify, can you handle the payment for @situchan since they found the bug and @parasharrajat for the PR.
I'm not sure of its process and i think you've to wait for the PR to be live first.

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@MelvinBot
Copy link

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@parasharrajat
Copy link
Member

PR merged

@bfitzexpensify bfitzexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 17, 2023
@melvin-bot melvin-bot bot changed the title Native platforms crashing due to nbsp outside Text component [$1000] Native platforms crashing due to nbsp outside Text component Apr 17, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~011dca5d263f2f7434

@MelvinBot
Copy link

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 17, 2023
@MelvinBot
Copy link

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@bfitzexpensify
Copy link
Contributor

Added external to get the Upwork job created. Unassigning others.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@bfitzexpensify bfitzexpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 20, 2023
@bfitzexpensify
Copy link
Contributor

Not due yet. @parasharrajat can you link the PR so I can subscribe to it?

@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2023
@parasharrajat
Copy link
Member

Here you go #17412

@bfitzexpensify
Copy link
Contributor

Thanks! Updating the title of this issue so I know when to check back and issue payment

@bfitzexpensify bfitzexpensify changed the title [$1000] Native platforms crashing due to nbsp outside Text component [Pay on 26-4][$1000] Native platforms crashing due to nbsp outside Text component Apr 21, 2023
@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels Apr 24, 2023
@bfitzexpensify
Copy link
Contributor

Offers sent out @parasharrajat @situchan

@MelvinBot
Copy link

@bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@bfitzexpensify
Copy link
Contributor

All paid out and contracts ended. We're all done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants