[HOLD for payment 2023-04-26] [$1000] The workspace chat shows the timezone and name of the admin

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log into newdot in an account that's a member of a workspace (but not an admin).
2. Click the workspace chat (chat name should be %domain name%'s workspace).
3. Confirm that you see the timezone and name of the workspace admin listed above the compose field.

Expected Result:

Timezone and name of the admin should not show

Actual Result:

Showing name and timezone of the admin

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @Julesssss
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679662638551609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194e62e57f0ce68c4
• Upwork Job ID: 1645535253337264128
• Last Price Increase: 2023-04-10

[MelvinBot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

Taking a look today!

[Julesssss]

Hi @kavimuru. Were you able to verify this on all the other platforms?

[joekaufmanexpensify]

@Julesssss @kavimuru mind sharing more specific reproduction steps here? I'm not sure how to access the screen Jules shared above.

[joekaufmanexpensify]

Nvm, was able to reproduce. Updated steps above!

[MelvinBot]

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

[joekaufmanexpensify]

@Julesssss assuming you want to keep this one internal?

[joekaufmanexpensify]

@Julesssss bump on this one whenever you have chance?

[Julesssss]

Thanks for the reminder! Now that you have reproduced I think we're good 👍

[Julesssss]

Actually, @kavimuru could you please verify the other platforms first?

[joekaufmanexpensify]

Not overdue

[kavimuru]

@Julesssss I can't create room with more than one admin. So I was not able to reproduce this issue.

[joekaufmanexpensify]

@Julesssss I'm happy to help reproduce. To clarify, you just want to make sure this exists on desktop, iOS, and android too, right?

[Julesssss]

@Julesssss I'm happy to help reproduce. To clarify, you just want to make sure this exists on desktop, iOS, and android too, right?

Thanks @joekaufmanexpensify. Yeah exactly. Knowing this will help us with the proposal reviews.

[MelvinBot]

📣 @Pujan92 You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Pujan92]

@joekaufmanexpensify @Julesssss Can you plz provide the beta permission access to my id shahpujanjio@gmail.com

[Julesssss]

I've added you to the beta. IIRC it takes a little while to process, but signing out and back in might speed this up.

[Pujan92]

PR is ready for review!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: workspace chat shows the timezone and name of the admin #17332

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR: This is more like a feature request
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@joekaufmanexpensify] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/278780

[fedirjh]

• The PR that introduced the bug has been identified. Link to the PR: cc @Julesssss This is more like a feature request
• The offending PR has been commented on : N/A
• A discussion in #expensify-bugs has been started : N/A

[joekaufmanexpensify]

@Pujan92 was assigned on 2023-04-12, and the PR was merged on 2023-04-13, so this qualifies for a speed bonus

[joekaufmanexpensify]

We need to make the following payments:

• @Pujan92 $1,500 ($1,000 will be contract amount, and $500 a bonus during payment).
• @fedirjh $1,500 ($1,000 will be contract amount, and $500 a bonus during payment).
• No reporting bonus here, as this was reported internally.

[joekaufmanexpensify]

@Pujan92 offer sent for $1,000!

[joekaufmanexpensify]

@fedirjh offer sent for $1,000!

[joekaufmanexpensify]

I think a regression test here makes sense. @fedirjh mind proposing the steps?

[fedirjh]

Regression Test Proposal

1. Login as a user that's a member of a workspace (but not an admin).
2. Click the Workspace Chat (chat name should be %domain name%'s workspace).
3. Confirm that you don't see the timezone and name of the workspace admin listed above the compose field.

Do we agree 👍 or 👎

[joekaufmanexpensify]

Regression test issue linked above. BZ checklist is now complete

[joekaufmanexpensify]

@fedirjh $1,500 sent and contract ended!

[joekaufmanexpensify]

@Pujan92 $1,500 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and payment issued. This is all set. Thanks everyone!