Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-07] Update Style Guide WRT React Hooks usage #16325

Closed
marcaaron opened this issue Mar 20, 2023 · 5 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

Task

  • Our style guide needs to be updated so that we can start using React hooks and deprecate class components. There are a lot of references to class components in general.
  • We also need to include the eslint plugin related to React hooks so that it will warn us when they are used incorrectly ("rules of hooks") or with missing dependencies ("exhaustive deps").
@marcaaron marcaaron self-assigned this Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@roryabraham
Copy link
Contributor

No C+ payment on this one

@MelvinBot
Copy link

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 31, 2023
@melvin-bot melvin-bot bot changed the title Update Style Guide WRT React Hooks usage [HOLD for payment 2023-04-07] Update Style Guide WRT React Hooks usage Mar 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 31, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@marcaaron
Copy link
Contributor Author

There is no payment needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants