Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-16] [$250] Migrate index.js to function component #16206

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 34 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d438ef7ce5ce1ce1
  • Upwork Job ID: 1683920221115404288
  • 2023-07-25
  • Automatic offers:
    • | | 0
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 6, 2023
@s-alves10
Copy link
Contributor

I'd love to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 22, 2023
@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@rayane-djouah
Copy link
Contributor

Can I work on this?

@ghost
Copy link

ghost commented Jul 15, 2023

Dibs

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@kosmydel
Copy link
Contributor

Hey, I am from the Software Mansion expert's agency. I am ready to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Monthly KSv2 labels Jul 25, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Jul 25, 2023
@Expensify Expensify deleted a comment Jul 25, 2023
@Expensify Expensify deleted a comment from payal-lathidadiya Jul 25, 2023
@Expensify Expensify deleted a comment from vadymbokatov Jul 25, 2023
@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 25, 2023

Would love to work on it

@situchan
Copy link
Contributor

This is not open to proposals. @kosmydel is already working on it.

@ybot1122
Copy link

I would like to work on this issue. Proposal:

  • Convert componentDidMount into React hook
  • Convert this.label into useRef
  • Convert this.props into destructured props object

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

📣 @ybot1122! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@ybot1122
Copy link

Contributor details
Your Expensify account email: ybotuil2211@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a330084df30132b1

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

@marcaaron, @zanyrenney, @kosmydel, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Aug 4, 2023

@marcaaron, @zanyrenney, @kosmydel, @situchan Huh... This is 4 days overdue. Who can take care of this?

@marcaaron
Copy link
Contributor Author

you are drunk @melvin-bot go home!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate index.js to function component [HOLD for payment 2023-08-16] [$250] Migrate index.js to function component Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@zanyrenney
Copy link
Contributor

As @kosmydel is part of agencies, there is only one payout here for @situchan - is that correct @marcaaron ? This issue looks a little different to the others we normally handle in BZ so just want to double check. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@situchan
Copy link
Contributor

@zanyrenney yes, correct.

@kosmydel
Copy link
Contributor

@zanyrenney From my side it is also correct, I'm from the SWM agency.

@marcaaron
Copy link
Contributor Author

That is correct!

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2023
@zanyrenney
Copy link
Contributor

That is all paid out!

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants