Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting- Send validation button is non functional on mobile #15345

Closed
4 of 6 tasks
kbecciv opened this issue Feb 22, 2023 · 15 comments
Closed
4 of 6 tasks

Setting- Send validation button is non functional on mobile #15345

kbecciv opened this issue Feb 22, 2023 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Feb 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15039

Action Performed:

  1. Log in with HT expensifail account applausetester+0901abb@applause.expensifail.com
  2. Go Settings - Profile
  3. Contact method
  4. Tap on phone number field
  5. Enter phone number
  6. Tap on Send validation

Expected Result:

User is able to add phone number as secondary log in

Actual Result:

Send validation button is non functional

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.75.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

15039.Android.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 22, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 22, 2023
@MelvinBot
Copy link

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Feb 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@lschurr
Copy link
Contributor

lschurr commented Feb 23, 2023

Confirmed. This works on web, but not mobile.

@lschurr
Copy link
Contributor

lschurr commented Feb 23, 2023

This looks similar but it was closed since it wasn't reproducible - #14685

Adding Eng for another set of eyes.

@MelvinBot
Copy link

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lschurr lschurr changed the title Setting- Send validation button is non functional Setting- Send validation button is non functional on mobile Feb 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2023
@nkuoch
Copy link
Contributor

nkuoch commented Feb 27, 2023

Sorry I can't reproduce from my staging App on IOS...

@melvin-bot melvin-bot bot removed the Overdue label Feb 27, 2023
@lschurr
Copy link
Contributor

lschurr commented Feb 27, 2023

Confirmed, I was able to get this working on mobile now as well.

@kbecciv - could you confirm if you're still seeing this bug?

@lschurr
Copy link
Contributor

lschurr commented Mar 1, 2023

Hi @kbecciv - Could you confirm if you're still able to produce this bug?

@kbecciv
Copy link
Author

kbecciv commented Mar 2, 2023

@lschurr Checking again, will update you shortly

@kbecciv
Copy link
Author

kbecciv commented Mar 2, 2023

@lschurr I checked with HT account applausetester+0901abb@applause.expensifail.com, the Send validation button is not functional.

Screen_Recording_20230302_130714_New.Expensify.1.mp4

Second account, I used regular expensifail account - applausetester+0707abb@applause.expensifail.com and Send validation button is functional, attach the video.

Screen_Recording_20230302_130420_New.Expensify.1.mp4

@lschurr
Copy link
Contributor

lschurr commented Mar 2, 2023

Hm, so it's working sometimes and others not. Going to add Needs reproduction to get more eyes on it.

@lschurr lschurr added the Needs Reproduction Reproducible steps needed label Mar 2, 2023
@lschurr
Copy link
Contributor

lschurr commented Mar 3, 2023

@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2023
@lschurr
Copy link
Contributor

lschurr commented Mar 6, 2023

Still waiting for some help to reproduce. Will bump in Slack again today.

@melvin-bot melvin-bot bot removed the Overdue label Mar 6, 2023
@lschurr
Copy link
Contributor

lschurr commented Mar 7, 2023

I tested again on both lschurr@expensifail.com and employee.lschurr@expensicorp.com on mobile - the Send Validation button worked both times.

@lschurr
Copy link
Contributor

lschurr commented Mar 7, 2023

I think we can close since we can't reliably reproduce this.

@lschurr lschurr closed this as completed Mar 7, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

4 participants